-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused Variable 'seen cue' #324
Comments
Seems pretty pointless now - I think I used to be used for collecting metadata headers before that got removed. |
Nope, I'm wrong, it came from a4bcfc1 |
Hmm, good catch. I think it should be set to true here
->
The intent is to drop STYLE etc blocks on the floor if a cue has been seen. |
@zcorpan Confirmed that setting |
This variable was intended to ignore STYLE and REGION blocks after having seen a cue, but it was never set to true. Fixes #324.
This variable was intended to ignore STYLE and REGION blocks after having seen a cue, but it was never set to true. Fixes #324.
Under 'WebVTT parser algorithm' (3.)
seen cue
is set to false, and is then only checked.Should this variable be removed? (can make a pr if so)
The text was updated successfully, but these errors were encountered: