Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to apply lineAlign before CSS has been applied #116

Merged
merged 1 commit into from Oct 15, 2014

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 2, 2014

@foolip
Copy link
Member Author

foolip commented Sep 2, 2014

Please take a look. As you can see I haven't done the actual work of making lineAlign work. If that's a blocker for merging this, then one of us has to spend the time figuring out how to do it. It involves taking the bounding box of all of the lines.

@silviapfeiffer
Copy link
Member

Well, the "cue box" was supposed to be the bounding box, so this was supposed to deal with lineAlign.
You want to move this after point 10, right?
Wouldn't we also need to move point 7 after point 10 then?
I think the whole "Apply WebVTT Cue settings" might need a rewrite.

@foolip
Copy link
Member Author

foolip commented Sep 9, 2014

Now rebased.

This would have to go after "Apply the terms of the CSS specifications", yes. Something like step 12, which says things like "Decrease position by the width of the bounding box of the boxes in boxes."

Step 7 ("Determine the value of x-position or y-position for cue") is OK, because it doesn't do anything that depends on the layout, the "text track cue computed *" are computed from the VTTCue state alone.

@foolip
Copy link
Member Author

foolip commented Oct 14, 2014

Please take another look. I've made an attempt to apply lineAlign after the bounding box is known, but I'm not really sure this is how you wanted lineAlign to work.

@silviapfeiffer
Copy link
Member

Yes, I think that's correct.

silviapfeiffer added a commit that referenced this pull request Oct 15, 2014
Don't try to apply lineAlign before CSS has been applied
@silviapfeiffer silviapfeiffer merged commit 005e6ec into w3c:master Oct 15, 2014
@foolip foolip deleted the not-final-positions branch October 15, 2014 09:09
foolip added a commit to foolip/webvtt that referenced this pull request Oct 15, 2014
This was invalid markup, introduced in
w3c#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants