Fix #217: Clarify that only validators will validate language tags #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aphillips |
|
Ping @aphillips @r12a |
zcorpan
force-pushed
the
valid-language-tag
branch
from
448b109
to
4e13961
Compare
aphillips
reviewed
Mar 29, 2020
| @@ -2842,6 +2846,10 @@ Object">WebVTT Internal Node Objects</a> also have an ordered list of class name | |||
| their <dfn lt="WebVTT Node Object's applicable language">applicable language</dfn>, which is to be | |||
| interpreted as a BCP 47 language tag. [[!BCP47]]</p> | |||
|
|
|||
| <p class=note>User agents will add a language tag as the <a lt="WebVTT Node Object's applicable | |||
There was a problem hiding this comment.
I understand the goal of this note, but it seems like it isn't worded correctly, since we want to encourage user agents to supply a well-formed and valid language tag, but not require them to check the language tag. I would probably say:
User agents must add a language tag as the applicable language. While language tag should be a valid language tag [[!BCP47]], the user agent is not required to check the structure or contents of the language tag to ensure that this is so.
There was a problem hiding this comment.
Except notes are non-normative and shouldn't use normative keywords (must, should, required).
| @@ -3160,6 +3163,7 @@ <h3 class="heading settled" data-algorithm="WebVTT cue text parsing rules" data- | |||
| parent-child relationships so constructed form a tree structure. <a data-link-type="dfn" href="#webvtt-internal-node-object">WebVTT Internal Node Objects</a> also have an ordered list of class names, known as their <dfn data-dfn-type="dfn" data-lt="WebVTT Node Object’s applicable classes" data-noexport="" id="webvtt-node-objects-applicable-classes">applicable classes<a class="self-link" href="#webvtt-node-objects-applicable-classes"></a></dfn>, and a language, known as | |||
| their <dfn data-dfn-type="dfn" data-lt="WebVTT Node Object’s applicable language" data-noexport="" id="webvtt-node-objects-applicable-language">applicable language<a class="self-link" href="#webvtt-node-objects-applicable-language"></a></dfn>, which is to be | |||
| interpreted as a BCP 47 language tag. <a data-link-type="biblio" href="#biblio-bcp47">[BCP47]</a></p> | |||
| <p class="note" role="note">User agents will add a language tag as the <a data-link-type="dfn" href="#webvtt-node-objects-applicable-language">applicable language</a> even if it is not a valid or not even well-formed language tag. <a data-link-type="biblio" href="#biblio-bcp47">[BCP47]</a></p> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #217