Fix #252: Actually parse charrefs in annotation #266
Conversation
|
@foolip can you review? |
|
|
||
| <dd> | ||
|
|
||
| <p>Attempt to <a>consume an HTML character reference</a>, with the <a spec=html>additional |
There was a problem hiding this comment.
I think this is right, because HTML says "optionally with an additional allowed character, which, if specified where the algorithm is invoked, adds a character to the list of characters that cause there to not be a character reference."
Without any context, I assumed this meant that > would be allowed as part of the character reference, which would the opposite of the intended.
There was a problem hiding this comment.
Yeah the only difference from "no additional allowed character" is whether &> produces a parse error or not. WebVTT doesn't take note of the parse error, so for WebVTT there is technically no difference at all, currently. WebVTT's syntax doesn't allow lone ampersands, so it is a syntax violation regardless.
There was a problem hiding this comment.
Seems there's no actual difference... whatwg/html#364
|
👍 |
The syntax allowed charrefs in annotations, but the tokenizer didn't. Rename "HTML character reference state" to "HTML character reference in data state" and add a new "HTML character reference in annotation state". Switch into the new state when seeing "&" in the "WebVTT start tag annotation state".
zcorpan
force-pushed
the
charref-annotation
branch
from
ec52d07
to
148241b
Compare
The syntax allowed charrefs in annotations, but the tokenizer didn't.
Rename "HTML character reference state" to "HTML character reference
in data state" and add a new "HTML character reference in annotation
state". Switch into the new state when seeing "&" in the "WebVTT
start tag annotation state".
#252