Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby issue264 #347

Closed
wants to merge 6 commits into from
Closed

Ruby issue264 #347

wants to merge 6 commits into from

Conversation

@silviapfeiffer
Copy link
Member

silviapfeiffer commented May 6, 2017

Include rb as a ruby tag in WebVTT.

* added rb tag in syntax, parsing and rendering
* also ran format.py, which re-wrapped a few other paragraphs

Addresses issue #264

Copy link
Member

zcorpan left a comment

I think we shouldn't add this without first getting stated implementor commitment.

<li>A <a>WebVTT cue span end tag</a> "<code>rb</code>". If this is the last occurrence of this
group of components in the <a>WebVTT cue ruby span</a> or a <a>WebVTT cue span start tag</a>
"<code>rt</code>" is next, then this last end tag string may be omitted.</li>
</ol>

This comment has been minimized.

Copy link
@zcorpan

zcorpan May 8, 2017

Member

This appears to be wrong... It allows <ruby>foo<rt>bar<rb>baz</ruby>, but not <ruby><rb>foo<rt>bar</ruby>

@@ -3092,6 +3118,12 @@ string |input| supposedly containing <a>WebVTT cue text</a>, and optionally a fa
Object">attach</a> a <a>WebVTT Ruby Text Object</a>.</p>
</dd>

<dt>If the tag name is "<code>rb</code>"</dt>
<dd>
<p>If |current| is a <a>WebVTT Ruby Object</a>, then <a lt="attach a WebVTT Internal Node

This comment has been minimized.

Copy link
@zcorpan

zcorpan May 8, 2017

Member

Should this pop an rt? (And vice versa?)

@@ -4546,17 +4587,21 @@ corresponding <a lt="text track cue">cue</a>'s <a>WebVTT cue text alignment</a>:
''rgba(255,255,255,1)''. [[!CSS3-COLOR]]</p>

<p>The 'background' shorthand property on the <a>WebVTT cue background box</a> and on <a>WebVTT Ruby
Text Objects</a> must be set to ''rgba(0,0,0,0.8)''. [[!CSS3-COLOR]]</p>
Text Objects</a> and <a>WebVTT Ruby Base Text Objects</a> must be set to ''rgba(0,0,0,0.8)''.

This comment has been minimized.

Copy link
@zcorpan

zcorpan May 8, 2017

Member

No, not rb objects here.


<p>The 'white-space' property on the (root) <a>list of WebVTT Node Objects</a> must be set to
''white-space/pre-line''. [[!CSS21]]</p>
''white-space/pre-line'' and on <a>WebVTT Ruby Text Objects</a> and <a>WebVTT Ruby Base Text

This comment has been minimized.

Copy link
@zcorpan

zcorpan May 8, 2017

Member

Why was this added?


<p>The 'font-style' property on <a lt="WebVTT Italic Object">WebVTT Italic Objects</a> must be set
to ''font-style/italic''.</p>

<p>The 'font-weight' property on <a lt="WebVTT Bold Object">WebVTT Bold Objects</a> must be set to
''font-weight/bold''.</p>

<p>The 'font-size' property on <a>WebVTT Ruby Text Objects</a> must be set to ''font-size/50%''.</p>

This comment has been minimized.

Copy link
@zcorpan

zcorpan May 8, 2017

Member

Why was this added?

@dwsinger

This comment has been minimized.

Copy link

dwsinger commented May 18, 2017

On the implementation question, we have two implementations; the independent one would have to 'change' from ignoring rb because it's not specified in VTT into ignoring it because in the cases of ruby that VTT supports, it's not needed (a hard-to-detect change). The webkit one would have to make the simple change to not strip rb from text before passing it to the HTML engine (where it is implemented), so it would appear in the DOM etc.

zcorpan added a commit that referenced this pull request Jun 15, 2017
Fixes #264.
Closes #347.
zcorpan added a commit that referenced this pull request Jun 16, 2017
Fixes #264.
Closes #347.
@silviapfeiffer silviapfeiffer deleted the silviapfeiffer:ruby-issue264 branch Jun 25, 2017
@silviapfeiffer silviapfeiffer restored the silviapfeiffer:ruby-issue264 branch Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.