Ruby issue264 #347
Closed
Ruby issue264 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added rb tag in syntax, parsing and rendering * also ran format.py, which re-wrapped a few other paragraphs
zcorpan
reviewed
May 8, 2017
| <li>A <a>WebVTT cue span end tag</a> "<code>rb</code>". If this is the last occurrence of this | ||
| group of components in the <a>WebVTT cue ruby span</a> or a <a>WebVTT cue span start tag</a> | ||
| "<code>rt</code>" is next, then this last end tag string may be omitted.</li> | ||
| </ol> |
There was a problem hiding this comment.
This appears to be wrong... It allows <ruby>foo<rt>bar<rb>baz</ruby>, but not <ruby><rb>foo<rt>bar</ruby>
| @@ -3092,6 +3118,12 @@ string |input| supposedly containing <a>WebVTT cue text</a>, and optionally a fa | |||
| Object">attach</a> a <a>WebVTT Ruby Text Object</a>.</p> | |||
| </dd> | |||
|
|
|||
| <dt>If the tag name is "<code>rb</code>"</dt> | |||
| <dd> | |||
| <p>If |current| is a <a>WebVTT Ruby Object</a>, then <a lt="attach a WebVTT Internal Node | |||
There was a problem hiding this comment.
Should this pop an rt? (And vice versa?)
| @@ -4546,17 +4587,21 @@ corresponding <a lt="text track cue">cue</a>'s <a>WebVTT cue text alignment</a>: | |||
| ''rgba(255,255,255,1)''. [[!CSS3-COLOR]]</p> | |||
|
|
|||
| <p>The 'background' shorthand property on the <a>WebVTT cue background box</a> and on <a>WebVTT Ruby | |||
| Text Objects</a> must be set to ''rgba(0,0,0,0.8)''. [[!CSS3-COLOR]]</p> | |||
| Text Objects</a> and <a>WebVTT Ruby Base Text Objects</a> must be set to ''rgba(0,0,0,0.8)''. | |||
|
|
||
| <p>The 'white-space' property on the (root) <a>list of WebVTT Node Objects</a> must be set to | ||
| ''white-space/pre-line''. [[!CSS21]]</p> | ||
| ''white-space/pre-line'' and on <a>WebVTT Ruby Text Objects</a> and <a>WebVTT Ruby Base Text |
|
|
||
| <p>The 'font-style' property on <a lt="WebVTT Italic Object">WebVTT Italic Objects</a> must be set | ||
| to ''font-style/italic''.</p> | ||
|
|
||
| <p>The 'font-weight' property on <a lt="WebVTT Bold Object">WebVTT Bold Objects</a> must be set to | ||
| ''font-weight/bold''.</p> | ||
|
|
||
| <p>The 'font-size' property on <a>WebVTT Ruby Text Objects</a> must be set to ''font-size/50%''.</p> |
|
On the implementation question, we have two implementations; the independent one would have to 'change' from ignoring rb because it's not specified in VTT into ignoring it because in the cases of ruby that VTT supports, it's not needed (a hard-to-detect change). The webkit one would have to make the simple change to not strip rb from text before passing it to the HTML engine (where it is implemented), so it would appear in the DOM etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include rb as a ruby tag in WebVTT.
Addresses issue #264