Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up section 6 a bit more to make it more readable. #398

Merged
merged 7 commits into from Dec 4, 2017
Merged

Break up section 6 a bit more to make it more readable. #398

merged 7 commits into from Dec 4, 2017

Conversation

silviapfeiffer
Copy link
Member

Closes #397

@silviapfeiffer
Copy link
Member Author

@dwsinger review required

@silviapfeiffer silviapfeiffer mentioned this pull request Nov 19, 2017
Closed
@silviapfeiffer
Copy link
Member Author

@nigelmegitt any feedback on this PR?

@nigelmegitt
Copy link
Contributor

@silviapfeiffer that's strange I'm sure I've looked at this and commented... Anyway, it's a big improvement, thank you. Reminder to self: section 5 Default Classes got added, so section 6 when I raised the issue has become section 7 in this PR.

nigelmegitt
nigelmegitt approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new structure is a big improvement over the previous. The GitHub web based diff makes it hard to verify there's no substantive change, so I'm "approving" the structural change without checking that part of it.

@silviapfeiffer
Copy link
Member Author

@nigelmegitt I didn't introduce fundamental text changes - most of it is just moved text to clarify things a bit.

@silviapfeiffer silviapfeiffer merged commit 8999f97 into w3c:gh-pages Dec 4, 2017
@silviapfeiffer silviapfeiffer deleted the sectioning-issue384 branch December 4, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

@dwsinger dwsinger dwsinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@silviapfeiffer @nigelmegitt @dwsinger