Remove hidden comments for cue and region settings #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't particularly illuminating, and the indentation would get mangled by format.py. Fixing format.py does not seem worthwhile.
|
Did you make sure that there is an example for every one of these cue settings in the spec? I've kept these around to remind me to write those examples and what they should contain. (Incidentally, some of these were taken over from Ian, too.) |
|
I've checked now. All regions settings are in examples, but for cues I can't find "vertical:" or "line:" in any example. Here's a bug to serve as the reminder: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25983 |
|
Thanks. |
silviapfeiffer
added a commit
that referenced
this pull request
Jun 5, 2014
Remove hidden comments for cue and region settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't particularly illuminating, and the indentation would get
mangled by format.py. Fixing format.py does not seem worthwhile.