-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modbus): introduce modbus type and byte/word order #331
Conversation
✅ Deploy Preview for wot-binding-templates ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly small changes, thanks @relu91 !
Looks good thanks! The rendering is broken somehow? Also, can you add https://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/#hexBinary to express bit arrays? Also in another PR, we should explain the mapping of the xsd types to what Modbus libraries would understand, i.e. saying that Also, we should have another PR where we explain how the Data Schema maps to the types in the form (and vice versa), i.e. having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in the call of 06.12, merging
@relu91 will regenerate the ontology file to resolve conflicts and can just merge asynchronously. |
Co-authored-by: Ege Korkan <egekorkan@gmail.com>
Co-authored-by: MahdaNoura <mahdanoura@gmail.com>
talked with @egekorkan we can merge it now. |
After the discussion in #293 this PR introduces three new terms to the modbus binding template:
modv:type
modv:mostSignificantByte
modv:mostSignificantWord
I did my best to explain the rationale behind the three new terms and provide a short example. About
modv:type
instead of introducing a new set of terms I decided to reuse XML Schema DataType but I tried to narrow them down to the list of this comment (let me know if I left something). I am not 100% sure about the design I chose for introducing this new property in the ontology, @mahdanoura if you can double-check it would be great. The rationale was that I needed a way to say that themodv:type
points to a valid XML Schema Data type among the ones we like. Not finding a class that covered all of them I created one and used a restriction. Let me know if it makes sense.