Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min Polling Interval in CoAP #352

Merged
merged 4 commits into from Mar 14, 2024
Merged

Min Polling Interval in CoAP #352

merged 4 commits into from Mar 14, 2024

Conversation

ektrah
Copy link
Member

@ektrah ektrah commented Feb 19, 2024

Resolves #349

@ektrah ektrah added the coap related to coap protocol binding label Feb 19, 2024
@ektrah ektrah requested a review from JKRhb as a code owner February 19, 2024 10:40
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for wot-binding-templates ready!

Name Link
🔨 Latest commit 3713e2d
🔍 Latest deploy log https://app.netlify.com/sites/wot-binding-templates/deploys/65f20011904d66000872baeb
😎 Deploy Preview https://deploy-preview-352--wot-binding-templates.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the content however we are using the spec generation tooling. So the table row should be contributed at https://github.com/w3c/wot-binding-templates/blob/main/bindings/protocols/coap/ontology.ttl#L34 and the text should be done to index.template.html in the same directory. We also need to update the schema but that can be done easily.

@egekorkan egekorkan self-assigned this Feb 22, 2024
@egekorkan
Copy link
Contributor

In the call of 22.02, we have agreed on the content change. @egekorkan will fix the tooling to use the turtle file in the generation of the index.html

@egekorkan
Copy link
Contributor

I have done the changes as agreed upon. Looking at 9715671 there is no real change in the index.html. I have also added this field to json schema

@egekorkan
Copy link
Contributor

@ektrah and @JKRhb can you have a final look and give ok? We can merge it asynchronously :)

@egekorkan
Copy link
Contributor

@JKRhb if fine with you as well, you can merge it :)

@JKRhb
Copy link
Member

JKRhb commented Mar 14, 2024

@JKRhb if fine with you as well, you can merge it :)

Thank you, Ege, looks good to me! :)

@JKRhb JKRhb merged commit 53ab773 into w3c:main Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coap related to coap protocol binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max Polling Time in CoAP
4 participants