-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to paginated TD retrieval spec #130
Conversation
"limit": { | ||
"description": "The number of TDs in the collection", | ||
"type": "number", | ||
"default": 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastiankb @mmccool Is there a way to set default values in TD?
The URI Template does not support it after draft v5 and I couldn't find anything in the TD's DataSchema either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to create an issue about this in the TD repo, otherwise it may not get addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for my late response. TD allows to use terms which are not defined in data schema yet. Information can be found here https://w3c.github.io/wot-thing-description/#sec-data-schema-vocabulary-definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll reply on the new issue: w3c/wot-thing-description#1093
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving the review, as only remark I would add the optional functionality to return in the header the pair "Link" and an ontology class URI (as specified in the LDPP). In this way when the TDs are returned by using the headers one could know the types of these TDs.
We could try to fully comply with RFC7233 Range Requests. This would let us query range of bytes (or range of TDs) by setting equivalent request headers. To have dedicated resource URLs for the RESTful API, we could allow passing range request values in query. E.g.:
The above is inline with LDP Paging. Moreover, we could borrow LDPP's Links spec to have next link and etag to identify the state. |
@farshidtz it makes sense to have both ranges, maybe we could even define others. I like the approach, it is sensible. |
index.html
Outdated
Response: | ||
<pre> | ||
HTTP/1.1 200 OK | ||
Content-Range: TDs 10-12/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the range should be "10-11"
Otherwise it would be 3 more TDs and the count 12 does not match (0-11)
Closing without merging, but as discussed Farshid will create a new PR with equivalent (but improved) content. |
Preview | Diff