Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DirectoryDescription to ThingDirectory #161

Merged
merged 1 commit into from May 3, 2021

Conversation

benfrancis
Copy link
Member

@benfrancis benfrancis commented Apr 22, 2021

This PR proposes renaming DirectoryDescription to ThingDirectory as discussed in #133 and #43


Preview | Diff

@mmccool
Copy link
Contributor

mmccool commented Apr 26, 2021

@farshidtz suggests we apply refactoring PRs to a branch first to make sure they collectively don't break the spec while we are working on them. I created a branch ("refactor") but @benfrancis needs to redirect his PRs to it.

@benfrancis
Copy link
Member Author

@mmccool Hmm, which commits do you want to see combined? Can I suggest just cherry-picking the ones you want to see combined in a local clone? A refactor branch sounds like it will create more work.

If it helps you can see the combined result of my four PRs here and a rendered version here.

@farshidtz
Copy link
Member

It isn't about the commits. The suggestion is to change the target branch of all your refactoring PRs (#158, #159, #160, #161) from main to refactor.

This way, we can merge those PRs and fix the relevant text and ontology without breaking the draft spec that is served from main.

@benfrancis benfrancis changed the base branch from main to refactor April 30, 2021 16:25
@benfrancis
Copy link
Member Author

The suggestion is to change the target branch of all your refactoring PRs (#158, #159, #160, #161) from main to refactor.

Done.

@mmccool mmccool merged commit eaad9b8 into w3c:refactor May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants