Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Discoverer section #337

Merged
merged 1 commit into from Jun 13, 2022
Merged

Clean up Discoverer section #337

merged 1 commit into from Jun 13, 2022

Conversation

mmccool
Copy link
Contributor

@mmccool mmccool commented Jun 13, 2022 •
edited by pr-preview bot

Remove some text from the "Discovery Process" section:

  • Remove mention of file URLs. It's not clear we want to support these, and if we do, they should be mentioned as a protocol in the TD Server section, and they are not.
  • Remove examples around CoAP, and statements saying that other protocols than HTTP can be used. This does not disallow CoAP or other protocols, as they were only examples, but this decouples this section from the question of whether we support CoAP or not. So now the specification of what protocols are allowed are JUST in the relevant "exploration" sections.
  • Got rid of an unnecessary editor's note.

Preview | Diff

@mmccool mmccool requested review from farshidtz and JKRhb June 13, 2022 13:36
relu91
relu91 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the remove statements were nice examples/clarifications, but I agree that they are quite controversial given the current status. Ok for merge 👍🏻

@mmccool mmccool merged commit c7bac4d into w3c:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@JKRhb JKRhb JKRhb approved these changes

@farshidtz farshidtz Awaiting requested review from farshidtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmccool @relu91 @JKRhb