Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR publication prep and IR finalization #430

Merged
merged 30 commits into from
Oct 26, 2022
Merged

CR publication prep and IR finalization #430

merged 30 commits into from
Oct 26, 2022

Conversation

mmccool
Copy link
Contributor

@mmccool mmccool commented Oct 18, 2022

  • Updates to CR:
    • small wording change in at-risk section: "deployments" -> "deployment policy"
    • to be consistent with versions of text used in Architecture and Thing Description
  • Updates to test results
    • CoAP and CoRE-RD improvements, several at-risk items removed

NOTE: IR is still held in DRAFT status and is so marked. It will be updated as soon as possible to address the issues noted. An ednote for IANA will be added as well.

To do:

  • Update IR, dates, etc. consistent with Architecture and TD IRs

@mmccool mmccool changed the title Cleanup of CR publication prep CR publication prep and IR finalization Oct 21, 2022
@k-toumura
Copy link
Contributor

@mlagally
Copy link

Some review comments:

  1. The description contains a broken reference to the implementation reports in Section 3.

Implementer reports were collected through the W3C WoT Interest Group's PlugFest activity and collected in the GitHub repository https://github.com/w3c/wot under testing/tests/2019-05/.

  1. There are no implementation descriptions contained in section 6.

  2. Section 8 would benefit from a legend that explains the meaning of "P F N T"

@egekorkan
Copy link
Contributor

egekorkan commented Oct 25, 2022

@mlagally here are some explanations for your comments:

  1. I am not entirely sure but I think that this link is a placeholder. The Discovery document will be published under this link. @mmccool correct me if I am wrong.
  2. As it was also done with the TD, the implementation descriptions are in the architecture specification. This was decided quite some time ago but we can simply duplicate them into here in the CR transition. A first time reader might have the same question so we should link to the arch IR in the worst case.
  3. The Result list item at the bullet list in the beginning of Section 8 actually explains what these letters mean. However, this text can be overlooked and it would not hurt to add more information. A simple improvement would be to add the title attribute which would show the full text when the mouse is hovered over it. Also note that this is how we did in the TD 1.0 as well.

@mmccool
Copy link
Contributor Author

mmccool commented Oct 26, 2022

The implementation report updates for Discovery unfortunately are lagging behind those for TD and Architecture. Some of the issues noted are in the template and have been addressed already in the TD and Architecture versions of the report. Since we had a resolution to go to CR transition today in the main call for Discovery and don't want to delay that, I have marked the IR with the DRAFT title in this PR and will update it as soon as possible to address these issues. However, I want to merge this PR (as resolved in the main call) and deal with those issues in the IR in a new PR.

@mmccool mmccool marked this pull request as ready for review October 26, 2022 13:57
@mmccool mmccool merged commit 4b1eefe into w3c:main Oct 26, 2022
JKRhb pushed a commit to JKRhb/wot-discovery that referenced this pull request Mar 28, 2023
* updates

* include VIAMEE results

* sync result files

* rerun impl report gen

* manual changes

* update with latest atrisk css

* sotd and section-at-risk

* completed list of at-risk features

* mark sections and features at risk

* regen static version and html-tidied version

* update at-risk sotd with new results

* move two assertions to manual

* deployments -> deployment policy

* explicitly link at-risk assertions

* update crEnd to 2023-01-11

* latest results

* updated report, new CoAP/CoRE-RD results

* update sotd based on latest results

* add DRAFT to IR title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants