Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HTTP Baseline Profile to HTTP Basic Profile #265

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

benfrancis
Copy link
Member

@benfrancis benfrancis commented Aug 24, 2022

This is a follow-up to #260 which proposes renaming the "HTTP Baseline Profile" to the "HTTP Basic Profile".

The reason for this is that I think after the re-structure in #260 there's potential for confusion between the terms "Baseline Profile" and "Common Constraints". The term "baseline" may imply that all other HTTP profiles all have to be built on top of the HTTP Baseline profile, which is not the case since they can also be used on their own. This addresses similar historical concerns about the the term "Core Profile" (#5, #21).

Note that this PR builds on #260, so please only review the last commit 2bf7a55


Preview | Diff

@benfrancis benfrancis changed the title Rename HTTP Basline Profile to HTTP Basic Profile Rename HTTP Baseline Profile to HTTP Basic Profile Aug 24, 2022
Copy link
Contributor

@mlagally mlagally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name change is an improvement and should be also done in the diagrams, both in profile and architecture.

However this MR also contains many unrelated changes, presumably you branched from a different branch. Can you please constrain the scope of this MR to the name change only.

@benfrancis
Copy link
Member Author

However this MR also contains many unrelated changes, presumably you branched from a different branch. Can you please constrain the scope of this MR to the name change only.

Please read my comment from above:

Note that this PR builds on #260, so please only review the last commit 2bf7a55

This PR depends on #260 because the name change is largely motivated by the re-structure proposed in that PR. I can rebase this PR once if and when that one lands.

@benfrancis
Copy link
Member Author

This PR depends on #260 because the name change is largely motivated by the re-structure proposed in that PR. I can rebase this PR once if and when that one lands.

This has now been done so this change can be reviewed on its own.

should be also done in the diagrams, both in profile and architecture.

Hopefully this can be done as a follow-up as I can't find the source code of the diagrams concerned.

@mlagally
Copy link
Contributor

mlagally commented Aug 31, 2022

Thanks @benfrancis - I consider this ready to merge.

The diagram source for the sequence diagram is at: "images/Sequence Diagram - WebHook.puml"
You can use Plantuml to render the diagram.
The other diagrams are completely outdated and were drawn in Powerpoint.
It would be easier to recreate them in Draw, after we have consolidated the spec.

@mlagally
Copy link
Contributor

Profile call on Sept 21. - Agree to merge after the merge conflict has been resolved.
Please create another issue for the diagram(s)

@benfrancis
Copy link
Member Author

@mlagally I have resolved the merge conflict and I believe this is now ready to merge.

I have filed #290 to follow up on updating Figure 1.

@benfrancis
Copy link
Member Author

@mlagally I would be grateful if you could land this PR ASAP so that I have an opportunity to resolve any resulting merge conflicts in my other 9 PRs before tomorrow's meeting, so the same thing doesn't happen again. Thank you.

@mlagally mlagally merged commit 3d4a8cb into w3c:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants