Make sychronous member of ActionAffordance mandatory - closes #405 #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfrancis
requested review from
mmccool,
sebastiankb,
mryuichi,
chachamimm and
mlagally
lu-zero
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #405
I don't like that this adds an additional mandatory term to ActionAffordances, but if this really is currently the only case where a Thing compliant with the HTTP Basic Profile will break a generic Consumer, then I think it's worth being more strict.
(I would also be happy to just make it mandatory for async actions to set
synchronoustofalse)Preview | Diff