Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some text improvements #48

Closed
wants to merge 6 commits into from
Closed

Some text improvements #48

wants to merge 6 commits into from

Conversation

sebastiankb
Copy link
Contributor

@sebastiankb sebastiankb commented Oct 9, 2020

based on discussion in #47


Preview | Diff

@sebastiankb
Copy link
Contributor Author

@mlagally Please can you share the source of the figures.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
The present document defines a WoT Profile that enables out of the box interoperability
among things and devices. It defines a set of constraints and rules that compliant
thing descriptions have to adopt to ensure interoperability.
This document introduce a WoT profile concept that supports the so-called <i>out of the box interoperability</i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This language is less clear than the previous text and waters down the purpose of the core profile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is the same content. However, I changed the word "introduces" to "defines". What do you think?

index.html Outdated
@@ -116,25 +116,33 @@
profile in an unambiguous way. This mechanism can be
used to define additional profiles.
</li>
<li>In addition it defines a <strong><a>Core
<li>It define a first base <strong><a>Core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clarify what you mean with "a first base"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you call as "Core" is the first introduced Profile in the specification, right? So it is the "first base".
However, I have no hard opinion about that. We can change this back if you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the 'base' term in the text

tests that were conducted as part of the development. It
is expected that additional profiles for thing templates
and other protocols will be defined in the near future.
the HTTP(S) and selected sub-protocols (e.g., for eventing).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should talk / or select subprotocols. Current proposed event mechanisms include SSE and Longpoll.
These just use HTTP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSE and Longpoll are sub-protocols of HTTP. This is aligned with the current TD spec. Please also see https://www.w3.org/TR/wot-thing-description/#form

@mlagally
Copy link
Contributor

@sebastiankb The sources of the drawio files are embedded in the svg files.

@sebastiankb
Copy link
Contributor Author

@mlagally

The sources of the drawio files are embedded in the svg files.

I only see this here https://github.com/w3c/wot-profile/tree/master/images

Where are the drawio files?

@mlagally
Copy link
Contributor

@sebastiankb agreed to close without merging (Arch call on 15.10)

@mlagally mlagally closed this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants