Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update listener internal slots to map<name, structure> #470

Open
zolkis opened this issue Apr 5, 2023 · 3 comments
Open

Update listener internal slots to map<name, structure> #470

zolkis opened this issue Apr 5, 2023 · 3 comments
Labels
enhancement Thoughts and ideas about possible improvements

Comments

@zolkis
Copy link
Contributor

zolkis commented Apr 5, 2023

Currently internal slots for [[readHandlers]], [[writeHandlers]], etc. are a map from name to a handler function.

Besides that function, the steps require saving |options| and other information as well.
So the internal slots will need to contain an object like

dictionary HandlerData {
    required function handler;
    sequence<InteractionOptions> subscriberOptions;
    sequence<any> subscriberData;
}

We could also add the |interaction| for convenience, but it can me retrieved using |name|.

@relu91 relu91 added the enhancement Thoughts and ideas about possible improvements label Apr 24, 2023
@relu91
Copy link
Member

relu91 commented Apr 24, 2023

Call 24/04/2023:

  • It is an improvement, but let's postpone it after publication.

@relu91
Copy link
Member

relu91 commented May 15, 2023

Call 15/05/2023

  • @zolkis @relu91 we'll check if the new version contains the proposed structure for [[readHandlers]]

@relu91
Copy link
Member

relu91 commented Dec 11, 2023

I can confirm that the current structure of the internal slot [[readHandlers]] is not the same as described above. My question is do we have evidence requiring the data contained in the updated dictionary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Thoughts and ideas about possible improvements
Projects
None yet
Development

No branches or pull requests

2 participants