New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #280 and 281: add emitPropertyChange(), remove ConsumedThing inheritance #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve. Minor comments:
- Could we link the first editor's note also in the other algorithms? it might be handy when the document is read not linearly.
- Could we use camel case for ExposedThing internal slot
extd
. It might be confused with a shortened version ofextend
whereas it should be ExposedThingDescription. So it might be more intuitive to call itexTD
orexTd
.
Makes sense, done.
The algorithms say "selected by the implementation", which should be clear enough even without the ednote. Repeating the ednote everywhere would be too much clutter, given that it just repeats the last sentence. Perhaps we could remove even the first one? |
Nit: I am always in favor of spelling out "what" it is since exTD sounds like example TD to me. Why not name it along the lines what it is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am generally fine with the PR.
I added some comments that seem beneficial to me.
b28c5bc
to
5f3ad0c
Compare
…sumedThing inheritance from ExposedThing Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>
Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>
5f3ad0c
to
2306bca
Compare
add explicit emitPropertyChange() and remove ConsumedThing inheritance from ExposedThing
Signed-off-by: Zoltan Kis zoltan.kis@intel.com
Preview | Diff