Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUM manual.csv #374

Closed
wants to merge 10 commits into from
Closed

TUM manual.csv #374

wants to merge 10 commits into from

Conversation

FadySalama
Copy link
Contributor

add manual.csv for TUM devices

@egekorkan
Copy link
Contributor

@FadySalama Not sure what the manual-tum means inside node-wot. did you mean the flask-tum implementation?

Comment on lines 12 to 32
"td-context-default-language-direction-independence","null","However, when interpreting human-readable text, each human-readable string value MUST be processed independently."
"td-default-alg","null","The value associated with member alg if not given MUST be assumed to have the default value ES256."
"td-default-contentType","null","The value associated with member contentType if not given MUST be assumed to have the default value application/json."
"td-default-format","null","The value associated with member format if not given MUST be assumed to have the default value jwt."
"td-default-http-method","null","When no method is indicated in a form representing an Protocol Binding based on HTTP, a Default Value MUST be assumed as shown in the following table."
"td-default-http-method_get","null","The value associated with member GET if not given MUST be assumed to have the default value Form with operation type readproperty"
"td-default-http-method_post","null","The value associated with member POST if not given MUST be assumed to have the default value Form with operation type invokeaction."
"td-default-http-method_put","null","The value associated with member PUT if not given MUST be assumed to have the default value Form with operation type writeproperty."
"td-default-idempotent","null","The value associated with member idempotent if not given MUST be assumed to have the default value false."
"td-default-in-apikey","null","The value associated with member in if not given MUST be assumed to have the default value query."
"td-default-in-basic","pass","The value associated with member in if not given MUST be assumed to have the default value header."
"td-default-in-bearer","null","The value associated with member in if not given MUST be assumed to have the default value header."
"td-default-in-digest","null","The value associated with member in if not given MUST be assumed to have the default value header."
"td-default-op-actions","pass","The value associated with member op if not given MUST be assumed to have the default value invokeaction."
"td-default-op-events","pass","The value associated with member op if not given MUST be assumed to have the default value subscribeevent."
"td-default-op-properties","pass","The value associated with member op if not given MUST be assumed to have the default value Array of string with the elements readproperty and writeproperty."
"td-default-qop","null","The value associated with member qop if not given MUST be assumed to have the default value auth."
"td-default-readOnly","pass","The value associated with member readOnly if not given MUST be assumed to have the default value false."
"td-default-safe","pass","The value associated with member safe if not given MUST be assumed to have the default value false."
"td-default-success","null","."
"td-default-writeOnly","pass","The value associated with member writeOnly if not given MUST be assumed to have the default value false."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the default assertions make sense only for consumers since the Things here do not interpret this

@FadySalama FadySalama marked this pull request as ready for review October 12, 2022 14:38
@mmccool
Copy link
Contributor

mmccool commented Oct 28, 2022

I see there are changes requested still. I will watch for updates, but would like to update the IRs soon. I'll deal with the other PRs in the meantime (and leave this PR open) but please complete this PR as soon as possible and when it is ready I will merge and incorporate in the IRs.

@mmccool
Copy link
Contributor

mmccool commented Oct 28, 2022

Also, might want to rebase first as there were some overlapping changes to manual-tms etc.

@egekorkan
Copy link
Contributor

I think that main thing to change is adding the manual.csv here

@FadySalama
Copy link
Contributor Author

Sorry but the review is outdated, please recheck and tell me what needs to change so we can close this PR

@egekorkan
Copy link
Contributor

@FadySalama simply move the manual csv for the manual tms to https://github.com/w3c/wot-testing/tree/main/data/input_2022/TD/fischertechnik-factory-simulator since I have renamed the directory there. You will need to adjust the bash script accordingly.

Flask is fine :)

@egekorkan
Copy link
Contributor

There are too many merge conflicts and similar issues for a simple PR, please see #484

@FadySalama
Copy link
Contributor Author

Should I close this? @egekorkan

@egekorkan
Copy link
Contributor

Yes this can be closed

@egekorkan egekorkan closed this Nov 28, 2022
@FadySalama FadySalama deleted the tum-manuals branch December 5, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants