Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing RFC-2119 Keywords in Assertions #1523

Closed
mmccool opened this issue Jun 3, 2022 · 2 comments
Closed

Missing RFC-2119 Keywords in Assertions #1523

mmccool opened this issue Jun 3, 2022 · 2 comments
Assignees
@egekorkan
Labels
by CR transition by PR transition Comments addressed during the CR period PR available

Comments

@mmccool
Copy link
Contributor

mmccool commented Jun 3, 2022

The following assertions are missing RFC-2119 keywords:

  • tm-compose-name-collision
  • tm-rel-type-maximum
@github-actions github-actions bot added the needs-triage Automatically added to new issues. TF should triage them with proper labels label Jun 3, 2022
@mmccool mmccool mentioned this issue Jun 3, 2022
Merged
@egekorkan egekorkan added by CR transition by PR transition Comments addressed during the CR period and removed needs-triage Automatically added to new issues. TF should triage them with proper labels labels Jun 8, 2022
@egekorkan
Copy link
Contributor

tm-compose-name-collision should be updated to use SHOULD
tm-rel-type-maximum should be updated to use MUST

@egekorkan egekorkan self-assigned this Jun 15, 2022
sebastiankb added a commit that referenced this issue Jun 29, 2022
@sebastiankb
soves #1523
5a6f2d8
@sebastiankb sebastiankb mentioned this issue Jun 29, 2022
Merged
@sebastiankb
Copy link
Contributor

PR was merged. Issue will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egekorkan egekorkan

Labels
by CR transition by PR transition Comments addressed during the CR period PR available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmccool @sebastiankb @egekorkan