Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OracleReview] Hints #1600

Closed
egekorkan opened this issue Jul 24, 2022 · 5 comments
Closed

[OracleReview] Hints #1600

egekorkan opened this issue Jul 24, 2022 · 5 comments
Labels
by CR transition Propose closing Problem will be closed shortly if there is no veto. V1.1 should be resolved in v1.1

Comments

@egekorkan
Copy link
Contributor

In several sections, the text talks about hints, e.g. 5.3.4.1 Link:

type: "Target attribute providing a hint indicating what the media type [RFC2046] of the result of dereferencing the link should be."

To achieve interoperability this is not sufficient. it should be an assertion that only media type values defined by IANA MUST be used.

@github-actions github-actions bot added the needs-triage Automatically added to new issues. TF should triage them with proper labels label Jul 24, 2022
@egekorkan
Copy link
Contributor Author

My comment on this:

We define our own values as well so we cannot limit to IANA only. However, it would be a valid point to discuss whether we should limit it to what IANA defines + what we define. In any case, restricting these values should be done in TD2.0 since TD1.0 TDs might be using some custom values or annotated ones.

@egekorkan egekorkan added V1.1 should be resolved in v1.1 and removed needs-triage Automatically added to new issues. TF should triage them with proper labels labels Jul 24, 2022
@mlagally
Copy link
Contributor

mlagally commented Aug 3, 2022

@egekorkan
I still think the language should be a bit stronger. What about "SHOULD use IANA defined media types [RFC2046] where applicable"?

@mlagally
Copy link
Contributor

mlagally commented Aug 5, 2022

The comment was more generic than this discussion. Suggest to search for "hint" across the entire document.

@sebastiankb
Copy link
Contributor

I have always some difficulties to change something what was already available in the TD 1.0 such as the mentioned assertion above.

Please not that everything what is defined within the information model table are specified as assertion, and is also listed in the implementation report such as:

image

(Please ignore "MAY be included. Type boolean." its only visible in the implementation report and not in the spec)

My recommendation is to leave everything as it is.

@sebastiankb sebastiankb added the Propose closing Problem will be closed shortly if there is no veto. label Aug 8, 2022
@sebastiankb
Copy link
Contributor

from today's TD call, decided to close.

@mlagally if you disagree please reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by CR transition Propose closing Problem will be closed shortly if there is no veto. V1.1 should be resolved in v1.1
Projects
None yet
Development

No branches or pull requests

3 participants