Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OracleReview] 5.3.1.3 PropertyAffordance #1604

Closed
2 tasks
egekorkan opened this issue Jul 24, 2022 · 6 comments
Closed
2 tasks

[OracleReview] 5.3.1.3 PropertyAffordance #1604

egekorkan opened this issue Jul 24, 2022 · 6 comments
Labels
by CR transition Propose closing Problem will be closed shortly if there is no veto. V1.1 should be resolved in v1.1

Comments

@egekorkan
Copy link
Contributor

  • invalid combinations of op values: some combinations don't make sense and should be prohibited. Examples include observe+unobserve.
  • observable: RFC2119 SHOULD assertion
@github-actions github-actions bot added the needs-triage Automatically added to new issues. TF should triage them with proper labels label Jul 24, 2022
@egekorkan
Copy link
Contributor Author

My comment was:

Actually, exactly this makes sense. In MQTT, we have the default assumption that observing is subscribing and unobserving is unsubscribing on the same topic. Thus, in MQTT it would redundant to split the operations. This is also valid for events.

@egekorkan egekorkan added V1.1 should be resolved in v1.1 and removed needs-triage Automatically added to new issues. TF should triage them with proper labels labels Jul 24, 2022
@benfrancis
Copy link
Member

Actually, exactly this makes sense. In MQTT, we have the default assumption that observing is subscribing and unobserving is unsubscribing on the same topic. Thus, in MQTT it would redundant to split the operations. This is also valid for events.

This is also the case for Server-sent Events, where the same URL endpoint is implicitly used for both subscribing and unsubscribing (unsubscribing basically just involves closing the connection). See Example 22 in the HTTP SSE Profile.

@mlagally
Copy link
Contributor

mlagally commented Aug 5, 2022

The current text for observable says:

A hint that indicates whether Servients hosting the Thing and Intermediaries should provide a Protocol Binding that supports the observeproperty and unobserveproperty operations for this Property.

This should become an RFC assertion.

@egekorkan
Copy link
Contributor Author

Like I have said in a previous comment, all tables are assertive but we should probably capitalize this. See the implementation report screenshot below
image

@sebastiankb
Copy link
Contributor

Combinations of op values heavily depends on the used (sub-)protocols. I think, it is hard find useful restriction that has not a potential impact of a specific protocol.

observable: RFC2119 SHOULD assertion

it is an assertion (see Ege's comment above). Also see my comment here:

#1600 (comment)

Propose to close this issue.

@sebastiankb sebastiankb added the Propose closing Problem will be closed shortly if there is no veto. label Aug 8, 2022
@sebastiankb
Copy link
Contributor

from today's TD call, decided to close

@mlagally please reopen, if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by CR transition Propose closing Problem will be closed shortly if there is no veto. V1.1 should be resolved in v1.1
Projects
None yet
Development

No branches or pull requests

4 participants