Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default text direction example and assertion #1437

Merged
merged 3 commits into from Apr 13, 2022
Merged

Conversation

egekorkan
Copy link
Contributor

@egekorkan egekorkan commented Mar 15, 2022

@egekorkan
Copy link
Contributor Author

I have checked the correctness of the text with @FadySalama . This adds a MAY assertion by removing its editor's note and adds a corresponding example.

index.html Outdated

<p>
Strings on the Web [[?STRING-META]] suggests
both strong-first and language-based inferencing as means

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strong-first should be first-strong

index.html Outdated
@@ -3022,6 +3008,49 @@ <h3>Human-Readable Metadata</h3>
}
</pre>


<p>
Strings on the Web [[?STRING-META]] suggests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually suggest both first-strong and inference from language tags. We actually recommend metadata falling back to first-strong. About language tags we say:

This approach is only recommended as a workaround for situations that prevent the use of metadata.

Because you are using JSON-LD, you have metadata for the document as a whole and for individual string values (notably title and description). What you don't have is per-string direction in language maps (e.g. titles and descriptions) and you could recommend the use of the language tag for these.

I would thus tend to say:

Strings on the Web recommends the use of metadata to determine the <a>base 
direction</a> of string values. When metadata is not present, applications SHOULD 
use <a>first-strong detection</a>as a fallback. Language maps do not permit per-string
metadata: implementations MAY infer the base direction from the language tag (as
a better indicator than first-strong detection).

Note that the links are found in i18n-glossary (you can add to your xrefs to pick up automagically)

Comment on lines 1836 to 1838
Strings on the Web [[?STRING-META]] suggests
both strong-first and language-based inferencing as means
to determine the base text direction.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments

@egekorkan
Copy link
Contributor Author

@aphillips I have addressed your feedback. However, there is one small issue: we are using these definitions inside normative assertions but these definitions are informative in i18-glossary (which makes sense since it is just a glossary). Should I change something in the respec config?

Important note for spec editors: I have changed the respec config

@sebastiankb
Copy link
Contributor

from today's TD call:

  • the PR looks good for merge
  • still waiting for @aphillips feedback

Copy link

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@sebastiankb
Copy link
Contributor

many thanks!

@sebastiankb sebastiankb merged commit 404767a into main Apr 13, 2022
@egekorkan egekorkan deleted the ege-text-direction branch April 13, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No base direction metadata
3 participants