Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template.csv for testing #1498

Closed
wants to merge 3 commits into from
Closed

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented May 9, 2022

Update template.csv

@egekorkan
Copy link
Contributor

I would propose to merge it asap since this is a bot written by me doing the PR. It is also not a normative change

@mmccool
Copy link
Contributor

mmccool commented May 18, 2022

I would rather if this go in testing/assertions.csv. The testing/template.csv file is generated by my scripts, after I moved them away from assertions.csv so THAT location could be used by other scripts. I can move it, but I already moved it once :). Also, putting it in testing/inputs/results/template.csv... that was the old location, but is technically inputs for my scripts, and is not the best place for it (which is why I moved things like this to just under testing, as they are not actually inputs).

@sebastiankb
Copy link
Contributor

from today's TD call:

  • will not be merged
  • @egekorkan will update the github action

@egekorkan
Copy link
Contributor

@mmccool I have used the script in the arch repo but it is actually not sufficient. It does not go into the tables and result in 160 assertions instead of 330 that we normally get.

@egekorkan
Copy link
Contributor

Closing since I have updated this script quite a bit

@egekorkan egekorkan closed this Jun 9, 2022
@egekorkan egekorkan deleted the assertion-csv-sync branch June 9, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants