Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informative text and an example for relative tm:ref #1552

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Jun 23, 2022

As discussed in #1546, this PR adds a few informative sentences regarding relative tm:ref imports, as well as an additional example (which could probably be simplified).

Resolves #1546


Preview | Diff

Copy link

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON intendation of the example could be improved.
Apart from that: Looks good to me.

index.template.html Outdated Show resolved Hide resolved
index.template.html Outdated Show resolved Hide resolved
@sebastiankb
Copy link
Contributor

Thanks, looks good to me too. There could be more text about the example, however, in my view it's simple and kind of self-explanatory.

@sebastiankb
Copy link
Contributor

from today's TD call:

  • decided to merge
  • another issue will be created that we need another statement if the non-manditory properties should be derived into a TD instance or not (e.g., "genericTemperature")

@sebastiankb sebastiankb merged commit 97f591a into w3c:main Jun 29, 2022
@JKRhb JKRhb deleted the relative-tm-ref branch June 29, 2022 14:27
@JKRhb JKRhb mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly allow/mention relative tm:ref imports?
3 participants