-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHACLE Type fixes #1642
SHACLE Type fixes #1642
Conversation
I was digging into the issue too. I stumble upon this commit message from @ethieblin (original commit
Are we sure that |
Answering my own question, from the spec there seem no constraints on the usage of the two terms... https://www.w3.org/TR/shacl/#DatatypeConstraintComponent https://www.w3.org/TR/shacl/#NodeKindConstraintComponent |
Digging deeper, probably what @ethieblin meant in the commit above is that when the language tag is used all the string literals are tagged with the lang tag. This in practice means that the datatype of the literal became
|
Even though this PR would fix the renderer, it brings the issue of the use of SHACL shapes as validation for the RDF version of a TD. The use case is the following:
Note: Perhaps, adding a few tests like that in the repository would ensure that the JSON-LD context is compliant to the OWL ontology and to the SHACL shapes ? |
I think the question is, does it makes sense and is it even possible to state that
I think it might catch some errors, we can automate the check in the CI. |
Apart from the issue on the "datatype" vs sh:Literal issue, there are changes in this PR that make the SHACL rules not compliant with the TD ontology anymore. Also, you cannot state that a property expects both a sh:IRI and give it a datatype. SHACL rule:
RDF with an IRI as object. It raises a validation error.
RDF with a typed xsd:anyURI Literal as object. It raises a validation error.
|
@ethieblin many thanks for your feedback. I think we need to follow these strategies:
@ethieblin can you quickly check what can be the issue in the |
from today's TD call:
|
it seems there are some mistakes defined in the validation file coming from PR #1574. This result to strange rendering behavoir in PR #1638 and #1639 (many places have "any type" defined instead of the specific datatype).
This PR should fix this issue and the render script should work correct again.