Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table numbers and captions using new respec option v.2 #1772

Merged
merged 3 commits into from Mar 22, 2023

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Feb 8, 2023

This PR contains the changes of #1712 with an additional commit to fix the renderer. The history was a little messed up so I pointed directly to the main branch.

fixes #1256


Preview | Diff

@egekorkan egekorkan added the Editorial Issues with no technical impact on implementations label Feb 8, 2023
@danielpeintner
Copy link
Contributor

No review, just a comment/question.

I can see the table numbering where there wasn't anything before.
e.g., in 4. Namespaces 👍

grafik

Unfortunately I cannot click on it nor is there an ID generated so that I can point people to a specific table like
#id-of-my-table-about-X

Do you think this is possible also since it would be very useful.

@danielpeintner
Copy link
Contributor

danielpeintner commented Feb 9, 2023

Note: There is an id, see
https://pr-preview.s3.amazonaws.com/relu91/wot-thing-description/pull/1772.html#table-namespaces-used-in-tds

Unfortunately one needs to look into the HTML source code since the Table header is not clickable like examples or so.

@relu91
Copy link
Member Author

relu91 commented Feb 9, 2023

Note: There is an id, see https://pr-preview.s3.amazonaws.com/relu91/wot-thing-description/pull/1772.html#table-namespaces-used-in-tds

Unfortunately one needs to look into the HTML source code since the Table header is not clickable like for examples or so.

Good point I'll try to add it.

@relu91
Copy link
Member Author

relu91 commented Feb 20, 2023

@danielpeintner unfortunately there is no built-in way to make the Table n° clickable: respec controls the generation of the caption label. However, in 180da57 I made the whole caption a link. What do you think? I'd be happier if I could add the link only in the Table n° but this way might still work.

Note: the other table captions need to be updated too.

@danielpeintner
Copy link
Contributor

danielpeintner commented Feb 21, 2023

There does not seem to be any link for some tables (Table 1 and 2)?
https://pr-preview.s3.amazonaws.com/relu91/wot-thing-description/pull/1772.html#table-namespaces-used-in-tds

I see that for Table 3 there is a link...
see https://pr-preview.s3.amazonaws.com/relu91/wot-thing-description/pull/1772.html#table-vocabulary-terms-in-thing-level

EDIT: I think changing just some was intentional, right @relu91 ?

BTW, there is an open feature request: w3c/respec#4222 and maybe we just need to wait...

@relu91
Copy link
Member Author

relu91 commented Feb 22, 2023

EDIT: I think changing just some was intentional, right @relu91 ?

Yes it was, I just didn't want to change all if you don't decide to go in that direction

BTW, there is an open feature request: w3c/respec#4222 and maybe we just need to wait...

Ah cool, somehow I missed it. Let's decide int today's call.

@egekorkan
Copy link
Contributor

Call of 22.02: We will wait for respec to have the automatic links otherwise the manual part can be done.

@relu91
Copy link
Member Author

relu91 commented Feb 27, 2023

PR in flight: w3c/respec#4392

@relu91
Copy link
Member Author

relu91 commented Mar 20, 2023

PR in flight: w3c/respec#4392

PR merged, release should be done soon.

@egekorkan
Copy link
Contributor

@relu91 given that the release has also happened, what should we do with this PR?

@relu91
Copy link
Member Author

relu91 commented Mar 22, 2023

ready to be merged 👍🏻

@egekorkan
Copy link
Contributor

Call of 22.03: No objections, merging since it is an informative change.

@egekorkan egekorkan merged commit 6bdfbf3 into w3c:main Mar 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial Issues with no technical impact on implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbering tables
3 participants