Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of atrisk section #1858

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Remove mention of atrisk section #1858

merged 2 commits into from
Sep 20, 2023

Conversation

egekorkan
Copy link
Contributor

this was an oversight due to some sparql rules not getting updated. Somehow it was not part of the atrisk.css :/

@JKRhb
Copy link
Member

JKRhb commented Jul 26, 2023

As it seems, the bug is caused by an at-risk note that is still present in the .ttl file:

skos:editorialNote "at risk" ;

I guess it would probably make sense to remove that one instead/additionally?

@egekorkan
Copy link
Contributor Author

As it seems, the bug is caused by an at-risk note that is still present in the .ttl file:

skos:editorialNote "at risk" ;

I guess it would probably make sense to remove that one instead/additionally?

Ah yes that is the real source of the problem! I wanted to do it asap yesterday and maybe went for a dirtier fix ^^

@egekorkan
Copy link
Contributor Author

Done. It also had 0 changes on the index.html

@egekorkan
Copy link
Contributor Author

TD Call of 26.07: The TF agrees that this PR can be merged after getting approval from PLH.

@egekorkan egekorkan added the changes index.html a PR that changes the index.html text label Aug 2, 2023
Copy link
Member

@chrisn chrisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@ashimura
Copy link
Contributor

ashimura commented Aug 8, 2023

Thanks a lot, @chrisn !

@ashimura
Copy link
Contributor

This PR has been approved by @plehegar , so let's merge this :)

@egekorkan
Copy link
Contributor Author

Call of 20.09: Merging

@egekorkan egekorkan merged commit 91873de into main Sep 20, 2023
1 check passed
@egekorkan egekorkan deleted the ege-atrisk-removal branch September 20, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants