Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Smartcity Dashboard UC #86

Merged
merged 3 commits into from
Feb 23, 2021
Merged

Conversation

mmccool
Copy link
Contributor

@mmccool mmccool commented Jan 14, 2021

  • Updated MD version to address feedback and comments
  • HTML conversion done
  • Converted HTML merged into index.html
  • Moved smartcity-dashboard.md to "processed" directory
  • Added some missing paragraph breaks to both smartcity-dashboard and smartcity-geolocation
  • Preliminary list of stakeholders generatd (ed note indicates this needs further review)

TO DO:

  • References. I can add any suggested during review.

Preview | Diff

@mmccool mmccool marked this pull request as draft January 14, 2021 17:07
@mmccool mmccool changed the title Update Smartcity Dashboard UC WIP: Update Smartcity Dashboard UC Jan 14, 2021
@mmccool mmccool changed the title WIP: Update Smartcity Dashboard UC Update Smartcity Dashboard UC Jan 16, 2021
@mmccool mmccool marked this pull request as ready for review January 16, 2021 22:58
@mlagally
Copy link
Contributor

mlagally commented Feb 9, 2021

UC call on 9.2.
@philip_tran@tech.gov.sg will review and update the PR.
We will revisit in next UC call on 23.2.

@@ -71,7 +71,8 @@ This use case also includes images from cameras and real-time image and data str
* Infrastructure status (water flow, electrical grid, road integrity, etc)
* Emergency sensing (flooding, earthquake, fire, etc.)
* Traffic (both people and vehicles)
* Health monitoring (eg fever tracking)
* Health monitoring (eg fever trackingi, mask detection, social distancing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'fever tracking' got extra i

<li>Infrastructure status (water flow, electrical grid, road integrity, etc)</li>
<li>Emergency sensing (flooding, earthquake, fire, etc.)</li>
<li>Traffic (both people and vehicles)</li>
<li>Health monitoring (eg fever trackingi, mask detection, social distancing)</li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To delete extra 'i' after 'fever tracking'

Copy link

@philiptran80 philiptran80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are inline with Jennifer's feedback from previous PR #38; just a small typo error to fix as commented.

<dd>

<dt>Variants</dt><dd>
<p>
<ul>
<li>A version of the system may log historical data so the past</li>
locations of the devices can be recovered.
Copy link

@philiptran80 philiptran80 Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</li> should be at this line 1892 instead of 1891.

@@ -1927,48 +1897,44 @@ <h2>Smart City Geolocation</h2>
<li>Geofencing may be implemented using event notifications and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</li> should be at this line 1896 instead of line 1893 above.

@mlagally mlagally merged commit 80b0c02 into w3c:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants