Fix Chrome support so that --webdriver-binary is required and --binar…

…y is optional
w3c · Apr 15, 2015 · ae6dc5f · ae6dc5f
1 parent 1ee211b
commit ae6dc5f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/wptrunner/browsers/chrome.py b/wptrunner/browsers/chrome.py
@@ -20,7 +20,7 @@
 
 
 def check_args(**kwargs):
-    require_arg(kwargs, "binary")
+    require_arg(kwargs, "webdriver_binary")
 
 
 def browser_kwargs(**kwargs):
@@ -34,9 +34,9 @@ def executor_kwargs(test_type, server_config, cache_manager, **kwargs):
     executor_kwargs = base_executor_kwargs(test_type, server_config,
                                            cache_manager, **kwargs)
     executor_kwargs["close_after_done"] = True
-    executor_kwargs["capabilities"] = dict(DesiredCapabilities.CHROME.items() +
-                                           {"chromeOptions":
-                                            {"binary": kwargs["binary"]}}.items())
+    executor_kwargs["capabilities"] = dict(DesiredCapabilities.CHROME.items())
+    if kwargs["binary"] is not None:
+        executor_kwargs["capabilities"]["chromeOptions"] = {"binary": kwargs["binary"]}
 
     return executor_kwargs