Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Commit

Permalink
Fix incorrect sorting of manifests when loading tests.
Browse files Browse the repository at this point in the history
This previously meant that manifests may be loaded in a random order, which
isn't great when combined with chunking.
  • Loading branch information
jgraham committed Aug 12, 2015
1 parent 404f561 commit bff4c17
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion wptrunner/testloader.py
Expand Up @@ -496,7 +496,7 @@ def load_metadata(self, test_manifest, metadata_path, test_path):
def iter_tests(self):
manifest_items = []

for manifest in sorted(self.manifests.keys()):
for manifest in sorted(self.manifests.keys(), key=lambda x:x.url_base):
manifest_iter = iterfilter(self.manifest_filters,
manifest.itertypes(*self.test_types))
manifest_items.extend(manifest_iter)
Expand Down

0 comments on commit bff4c17

Please sign in to comment.