Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wa extensions #8

Merged
merged 14 commits into from
Oct 10, 2017
Merged

Wa extensions #8

merged 14 commits into from
Oct 10, 2017

Conversation

iherman
Copy link
Member

@iherman iherman commented Oct 8, 2017

@iherman
Copy link
Member Author

iherman commented Oct 8, 2017

This PR contains all the changes to the Selectors and States document and also to the WA model that was discussed. Namely

This PR closes #5, more exactly supersedes it. Note also Issue #2, which to see if the second addition to the document should remain or should be removed.

Similarly, this PR closes #4.

@azaroth42
Copy link

I would flip the order of 3.10 (refinedBy) and 3.11 (EmbeddedResourceSelector) but otherwise it looks like a good first cut for discussion.

👍

@iherman
Copy link
Member Author

iherman commented Oct 9, 2017 via email

@azaroth42
Copy link

Good point. A simpler example for ERS could be:

{
  "type": "EmbeddedResourceSelector",
  "value": "/images/logo.jpg"
}

For a comment about the logo image embedded in the publication.

@tcole3
Copy link
Collaborator

tcole3 commented Oct 9, 2017

Are there any real-world use cases where a component (with its own URL) of a Web Publication is likely to appear (be embedded) in multiple locations within the Web Publication? If so, do any of these use cases require the ability to reference a particular occurrence of the component within the Web Publication? Originally I had thought we might be able to avoid need for ERS through the use of scope, but if we really need to define an ERS anyway, we want to make sure it sufficient to meet as many realistic use cases as possible.

@iherman
Copy link
Member Author

iherman commented Oct 9, 2017 via email

@iherman
Copy link
Member Author

iherman commented Oct 10, 2017

@azaroth42 @tcole3 @BigBlueHat: I will merge this PR. Not because it is a final version, but it may help us to do more fine-grained editings and PR-s.

@iherman iherman merged commit 00dde53 into master Oct 10, 2017
@iherman iherman deleted the WA-Extensions branch October 10, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants