New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @
from keywords
#332
Conversation
Based on the discussion on #312 this PR does what we have decided. However, we may want to wait a bit to see if the changes in the JSON schema are fine or not (@HadrienGardeur). Then again, if there is an issue, that can be taken care of later... |
schema/publication.schema.json
Outdated
@@ -223,4 +223,4 @@ | |||
} | |||
}, | |||
"required": ["@context", "url", "@type"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed from @type
to type
as well.
@HadrienGardeur thanks, I missed this one. I have changed that, too. Merging and closing now. |
Removed the
@
sign from the JSON-LD keywords@id
,@type
,@language
, and@value
, as agreed on a call for #312. (Not closing that issue, because there is still editorial work do to related to that issue. This meanttype
term is now both a json schema keyword and a term in the data. I hope json schema can cope with that)I have also
rel='canonical'
.Fix #324
Preview | Diff