Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaStream Image Capture #133

Closed
dontcallmedom opened this issue Aug 31, 2016 · 5 comments
Closed

MediaStream Image Capture #133

dontcallmedom opened this issue Aug 31, 2016 · 5 comments
Assignees
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review

Comments

@dontcallmedom
Copy link

The WebRTC and Device & Sensors Working Groups would like the TAG review of MediaStream Image Capture, an API to capture still pictures from a MediaStream generating camera.

@travisleithead
Copy link
Contributor

The ergonomics of the API seem aligned with good principles. E.g.:

  • Uses Promises for potentially long-running operations.

Exposes ImageCapture as an "add-on" object to a MediaStreamTrack (a new constructable interface:

  • Why make this a separate constructable object, with the reflective 'videoStreamTrack' member? Could this be streamlined into the MediaStreamTrack as a partial interface to it instead?
  • Seems like 'getPhotoCapabilities' and the MediaStreamTrack's 'getCapabilities' are nearly the same. Is there a reason to have the separate method and property list?

Is 'grabFrame' really necessary? Isn't this already possible using a video/canvas element?

Consider allowing a DOMPoint in places where a Point2D dictionary could be used (DOMPoint from http://www.w3.org/TR/geometry-1/#DOMPoint). The DOMPoint handles points in 3d space, but the 'z' and 'w' coordinates are not required, and this may be useful for platform consistency. 

@travisleithead
Copy link
Contributor

Should do a re-review at next F2F to see how the spec has been developing.

@torgo
Copy link
Member

torgo commented Apr 27, 2017

Discussed at Tokyo f2f…

@triblondon
Copy link

Discussed at London F2F

@torgo torgo modified the milestones: tag-f2f-london-2017-07-25, tag-f2f-tokyo-2017-04-27 Jul 25, 2017
@torgo
Copy link
Member

torgo commented Jul 25, 2017

Agreed to close at f2f. @travisleithead will follow up on remaining issue w3c/mediacapture-image#142 .

@torgo torgo closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review
Projects
None yet
Development

No branches or pull requests

7 participants