Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request review for PauseFrame API #196

Closed
3 of 5 tasks
jkarlin opened this issue Sep 14, 2017 · 4 comments
Closed
3 of 5 tasks

Request review for PauseFrame API #196

jkarlin opened this issue Sep 14, 2017 · 4 comments
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review

Comments

@jkarlin
Copy link

jkarlin commented Sep 14, 2017

Hello TAG!

I'm requesting a TAG review of:

  • Name: PauseFrame API
  • Specification URL: none yet
  • Explainer, Requirements Doc, or Example code: Explainer
  • Tests: none yet
  • Primary contacts: jkarlin

Further details (optional):

You should also know that...

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and @-notify [github usernames]
@triblondon
Copy link

Overall impression: A number of us think this is a great idea. Others feel its a bit of a blunt instrument. We're wondering about:

  • CSS hover effects - do they continue in a paused frame?
  • Does a frame know it's been paused (after unpausing). Obviously it could be
  • Queue could grow very large while frame is paused?
  • Interaction with service workers?
  • Interaction with Houdini?
  • Naming: Pause and Frame are terms related to animation, is that confusing? We acknowledge that it's not a name that is in the API itself.
  • Can a page pause itself?

Some of these issues have already been raised on the tracker, but I've gather them here as a collective set of TAG feedback. Hope this is useful and we look forward to hearing more.

@jkarlin
Copy link
Author

jkarlin commented Sep 28, 2017

Thanks so much! I'm slow to respond for the next week or two but will dig into the issues asap.

@triblondon
Copy link

@jkarlin friendly ping. If you don't have any feedback on our review shall we close?

@jkarlin
Copy link
Author

jkarlin commented Nov 15, 2017

Yes, thank you very much for the feedback!

@jkarlin jkarlin closed this as completed Nov 15, 2017
@triblondon triblondon removed their assignment Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review
Projects
None yet
Development

No branches or pull requests

3 participants