Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersection Observer review #197

Closed
LJWatson opened this issue Sep 15, 2017 · 16 comments
Closed

Intersection Observer review #197

LJWatson opened this issue Sep 15, 2017 · 16 comments
Assignees
Labels
Progress: propose closing we think it should be closed but are waiting on some feedback or consensus

Comments

@LJWatson
Copy link

The WebPlat WG has just published the FPWD of Intersection Observer, triggering wide review. Thanks to its time in incubation, the spec already has good interop, so we're hopeful of moving to CR reasonably quickly.

We'd welcome a review by the TAG. Feedback no later than Friday 27th October would be appreciated, feedback earlier even more so.

Please file issues on the Intersection Observer repo. Thank you.

@dbaron
Copy link
Member

dbaron commented Sep 27, 2017

So one thing I need to investigate further is that it feels to me that intersection observer running before the animation frame callbacks seems wrong, I think it should run substantially after them, with a bunch of other stuff in between, since rAF is primarily a writing callback (so should be early, before the natural style/layout), whereas IntersectionObserver is primarily a reading callback (so should be late, after the natural style/layout). But I suspect that some of my concern there may be that I think where HTML describes the running of the animation frame callbacks being wrong. I think this requires a good bit of digging into (to see what current specs say, and how interoperable existing implementations are); it's related to our #72.

@plinss
Copy link
Member

plinss commented Sep 27, 2017

I have concerns about the rootMargin being a string based API. This should be using CSS Typed OM if not now, at least some point if the future. The spec should at a minimum have a note about a typed OM version of the margin.

@LJWatson
Copy link
Author

Gentle ping to remind you that we're looking for issues to be filed by the end of next week. Thanks.

@slightlyoff
Copy link
Member

slightlyoff commented Oct 31, 2017

Discussed on today's call. Sounds like the delivering timing needs a look.

/cc @szager-chromium

@plinss plinss modified the milestones: tag-telcon-2017-11-21, tag-telcon-2017-12-12 Nov 21, 2017
@torgo
Copy link
Member

torgo commented Dec 12, 2017

Discussed on today's telecon.

@plinss plinss added Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review and removed Progress: in progress labels Feb 1, 2018
@dbaron
Copy link
Member

dbaron commented Feb 1, 2018

I'd like to leave this open to monitor the progress on w3c/IntersectionObserver#263 and whatwg/html#3246 etc.

@plinss plinss modified the milestones: tag-telcon-2017-12-12, tag-telcon-2018-03-06 Feb 1, 2018
@slightlyoff
Copy link
Member

Per today's F2F, now for me to discuss open issues with @szager-chromium

@dbaron
Copy link
Member

dbaron commented Dec 19, 2018

... but I think, as I mentioned in w3c/IntersectionObserver#263 (comment), that the steps should be still later. I think this requires writing a bunch of tests to check what happens today, though...

@LJWatson
Copy link
Author

LJWatson commented Nov 5, 2019

@szager @dbaron what is the state of this now?

@dbaron
Copy link
Member

dbaron commented Mar 25, 2020

We separated out the more general bits into #489, but we're perhaps still leaving this open to wait on w3c/IntersectionObserver#263.

@plinss plinss removed this from the 2020-03-23-week milestone Jun 19, 2020
@plinss plinss added this to the 2020-09-07-f2f milestone Aug 24, 2020
@dbaron
Copy link
Member

dbaron commented Sep 23, 2020

@plinss and I are looking at this in a breakout in our virtual "Cork" face-to-face.

So we were leaving this open for w3c/IntersectionObserver#263, which is in turn waiting on whatwg/html#3246, which is in turn waiting on w3c/csswg-drafts#5115. While it would be nice to fix that sequence of things, we probably don't need to leave this review open for it.

These are also all referenced from #489.

@dbaron dbaron added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus and removed Big chunk of work Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review labels Sep 23, 2020
@dbaron
Copy link
Member

dbaron commented Sep 24, 2020

OK, we discussed in mini-plenary and we're happy closing this issue at this point. Thanks for requesting TAG review... a long time ago. Sorry this took so long.

@dbaron dbaron closed this as completed Sep 24, 2020
@LJWatson
Copy link
Author

Thank you @dbaron and @plinss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: propose closing we think it should be closed but are waiting on some feedback or consensus
Projects
None yet
Development

No branches or pull requests

7 participants