Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More restrictive hasEnrolledInstrument() for autofill data #407

Closed
2 tasks done
rsolomakhin opened this issue Aug 13, 2019 · 8 comments
Closed
2 tasks done

More restrictive hasEnrolledInstrument() for autofill data #407

rsolomakhin opened this issue Aug 13, 2019 · 8 comments
Assignees
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review Progress: propose closing we think it should be closed but are waiting on some feedback or consensus

Comments

@rsolomakhin
Copy link

rsolomakhin commented Aug 13, 2019

こんにちはTAG!

I'm requesting a TAG review of:

Further details:

  • Relevant time constraints or deadlines: Please review before September.
  • Self-Review Questionnaire on Security and Privacy is not applicable, since this is a behavior change to a part of an existing API.
  • I have reviewed the TAG's API Design Principles, although it does not seem to be applicable here either.
  • The group where the work on this specification is: Web Payments Working Group.

We'd prefer the TAG provide feedback as (please select one):

  • Leave review feedback as a comment in this issue and @-notify @rsolomakhin
@rsolomakhin rsolomakhin changed the title Please review: More restrictive hasEnrolledInstrument() for autofill instruments Please review: More restrictive hasEnrolledInstrument() for autofill data Aug 13, 2019
@plinss plinss changed the title Please review: More restrictive hasEnrolledInstrument() for autofill data More restrictive hasEnrolledInstrument() for autofill data Aug 21, 2019
@plinss plinss added this to the 2019-09-04-telecon milestone Aug 21, 2019
@dbaron
Copy link
Member

dbaron commented Aug 21, 2019

The TAG is unsure about whether TAG review is needed for an implementation change that doesn't require spec changes. If it's an issue that isn't important enough for the spec to specify clearly, then it's not clear why the TAG should be reviewing it.

That said, this does bring up the question of perhaps whether this should be specified in more detail in the spec. Given the expectations that Chrome is setting, are other implementations of this API going to have to do the same thing in order to be compatible with the expectations of the API's users? If so, then it might actually need to be in the spec.

@rsolomakhin
Copy link
Author

rsolomakhin commented Aug 21, 2019

Good point, @dbaron. I will bring this up at the next working group meeting to see whether this should be specced.

@ianbjacobs: Could you add this topic to the agenda, please?

@rsolomakhin
Copy link
Author

Sorry, I meant to CC @ianbjacobs.

@dbaron dbaron added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label Sep 4, 2019
@rsolomakhin
Copy link
Author

@dbaron : In today's WPWG meeting, the consensus appeared to lean toward adding non-normative notes about behavior of hasEnrolledInstrument() to the three specs:

  • Payment Request
  • Payment Handler
  • Basic Card

But the discussion is ongoing. We hope to come to a conclusion at the 2019 TPAC.

@alice alice removed this from the 2019-09-10-f2f-tokyo milestone Jan 27, 2020
@dbaron dbaron added this to the 2020-03-09-week milestone Mar 4, 2020
@hober
Copy link
Contributor

hober commented Mar 16, 2020

@rsolomakhin wrote:

the consensus appeared to lean toward adding non-normative notes about behavior[…] but the discussion is ongoing. We hope to come to a conclusion at the 2019 TPAC.

Did you come to a conclusion? What did you conclude?

@hober hober added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus and removed Progress: unreviewed labels Mar 16, 2020
@ianbjacobs
Copy link

@rsolomakhin, should we fold this discussion into other payment handler discussions we are having right now, and in particular:
https://docs.google.com/document/d/1C_xH-6sJb9UedrvifsvqS_2k_We0IlPSfWFo8Kg54ps/edit

@rsolomakhin
Copy link
Author

SGTM @ianbjacobs

@hober
Copy link
Contributor

hober commented May 26, 2020

@dbaron and I looked at this again in our F2F this week, and since this is still not likely to result in normative changes to the spec, we're going to close the issue. Please let us know if it turns out this will result in normative spec changes, so we can take another look!

@hober hober closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review Progress: propose closing we think it should be closed but are waiting on some feedback or consensus
Projects
None yet
Development

No branches or pull requests

7 participants