Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'setting-up-github-repositories' to use GitHub Actions. #13

Merged
merged 1 commit into from Jun 10, 2020
Merged

Update 'setting-up-github-repositories' to use GitHub Actions. #13

merged 1 commit into from Jun 10, 2020

Conversation

hober
Copy link
Contributor

@hober hober commented Jun 3, 2020

@hober hober added tools Related to GitHub, Slack, Jitsi, or one of our other tools. documentation Documenting our processes labels Jun 3, 2020
@hober hober requested a review from dbaron June 3, 2020 16:58
@hober hober self-assigned this Jun 3, 2020
@hober hober added this to PR needs review in hober Jun 3, 2020
@hober
Copy link
Contributor Author

hober commented Jun 3, 2020

I also filed speced/bikeshed#1688 to see if we can simplify this further in the future.

@plinss plinss merged commit 17e161a into master Jun 10, 2020
hober automation moved this from PR needs review to Done Jun 10, 2020
dbaron
dbaron approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda wonder if the example Makefile needs all of that, but it's fine for now.

hober automation moved this from Done to Needs merging Jun 10, 2020
@hober hober deleted the github-actions branch June 10, 2020 20:37
@hober
Copy link
Contributor Author

hober commented Jun 10, 2020

I kinda wonder if the example Makefile needs all of that, but it's fine for now.

Most of that is simply because it doesn't presume the Bikeshed file is named index.bs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaron dbaron dbaron approved these changes

Assignees

@hober hober

Labels
documentation Documenting our processes tools Related to GitHub, Slack, Jitsi, or one of our other tools.
Projects
hober
  
Needs merging
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hober @dbaron @plinss