Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus: Polkadot js Plus extension, Milestone 1 #387

Merged
merged 8 commits into from
Mar 15, 2022
Merged

Plus: Polkadot js Plus extension, Milestone 1 #387

merged 8 commits into from
Mar 15, 2022

Conversation

Nick-1979
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#778

@alxs
Copy link
Contributor

alxs commented Mar 5, 2022

Thank you for the delivery @Nick-1979. We'll look into it as soon as possible.

@ashlink11 ashlink11 self-assigned this Mar 10, 2022
@ashlink11
Copy link
Contributor

Good day, @Nick-1979!

My name is Ashley and I work as a Technical Grants Evaluator at W3F. Thank you for your milestone 1 delivery!

I have installed the Plus plugin on Chrome and successfully connected my account! I can see the proper balance; I was also able to run & pass your unit tests, thank you!

I am confused on how to add the "Westend genesis & info" & rebuild from source. I am relatively new to the Polkadot ecosystem, so please forgive me. I cannot find these files in your codebase:

@polkadot/networks/genesis.js
@substrate/ss58-registry/index.js

Am I supposed to find these files in your codebase? Where are these files located?

Once I know, then I can add the westend genesis & info. Thank you!

@Nick-1979
Copy link
Contributor Author

Nick-1979 commented Mar 14, 2022

Hi Ashley,

Some Polkadot packages do not  support Westend hence some tweaks are needed to add Westend to the supported chains .

The files to add westend are located in "node_modules' folder, which can be found in the root of the project (after that yarn has installed modules).

  1. add the following Westend genesis to "./node_modules/@polkadot/networks/genesis.js"

westend:['0xe143f23803ac50e8f6f8e62695d1ce9e4e1d68aa36c1cd2cfd15340213f3423e']

2a. add the following Westend network information to "./node_modules/@substrate/ss58-registry/index.js

{ "prefix": 42, "network": "westend", "displayName": "Westend", "symbols": [ "WND" ], "decimals": [ 12 ], "standardAccount": "*25519", "website": "https://polkadot.network" })

2b. In case that you can not find "@substrate" folder in node modules (because it is added in the latest update of @PolkaDot package) you can add the following to  "./node_modules/@polkadot/networks/ substrate.js" instead as mentioned in the project readme file (https://github.com/Nick-1979/polkadot-Js-Plus-extension#to-test-on-westend).

{ decimals: [12], displayName: 'Westend', network: 'westend', prefix: 42, standardAccount: '*25519', symbols: ['WND'], website: 'https://polkadot.network' }

Finally a yarn build is needed to apply the changes.

The most convenient way to try the Westend is the compiled extension which is already available on Firefox addons page (https://addons.mozilla.org/en-US/firefox/addon/polkadot-js-plus-extension/).

If there are any other questions/issues I would be happy to answer/help.

Thank you, 

Kami 

Nick-1979 added a commit to Nick-1979/common that referenced this pull request Mar 15, 2022
Adding Westend genesis.

We are working on projects that utilize this package, In our projects we need to have Westend testnet, to let the community to try and learn Polkadot ecosystem.

Sometimes Developers have issues adding this manually as asked here: w3f/Grant-Milestone-Delivery#387 (comment),
 hence merging this pull request will help a lot.

Thank you.
Nick-1979 added a commit to Nick-1979/common that referenced this pull request Mar 15, 2022
We are working on projects that utilize this package, In our projects we need to have Westend testnet, to let the community to try and learn Polkadot ecosystem.

Sometimes Developers have issues adding this manually as asked here: w3f/Grant-Milestone-Delivery#387 (comment),
hence merging this pull request will help a lot.

Thank you.
jacogr pushed a commit to polkadot-js/common that referenced this pull request Mar 15, 2022
* Update README.md

ss58-registry.json link is updated the previous link does not work.

* Adding Westend genesis.

We are working on projects that utilize this package, In our projects we need to have Westend testnet, to let the community to try and learn Polkadot ecosystem.

Sometimes Developers have issues adding this manually as asked here: w3f/Grant-Milestone-Delivery#387 (comment),
hence merging this pull request will help a lot.

Thank you.

* Update genesis.ts
@ashlink11 ashlink11 merged commit d7d7853 into w3f:master Mar 15, 2022
@ashlink11
Copy link
Contributor

Hi Kami,

Thank you so much for your message. I've responded to it in my evaluation of your milestone.

I've accepted your milestone and forwarded your invoice.

It was a pleasure reviewing your project.

Sincerely,
Ashley

@RouvenP
Copy link

RouvenP commented Mar 22, 2022

hi @Nick-1979 we transferred the payment today. Thanks!

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants