Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamster milestone 1 delivery #397

Merged
merged 2 commits into from
Apr 6, 2022
Merged

hamster milestone 1 delivery #397

merged 2 commits into from
Apr 6, 2022

Conversation

ltmuyuan
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#789

@semuelle
Copy link
Member

Thank you for the delivery, @ltmuyuan. We will look into it as soon as possible.

@semuelle semuelle self-assigned this Mar 25, 2022
@semuelle
Copy link
Member

Hi @ltmuyuan. Thanks for waiting. I started looking into your delivery. The dockerized versions all seem to work fine, but I'm having trouble reproducing this locally. Do you know what might be the issue here?

$:~/deliverables/hamster/hamster-client$ go install -v github.com/wailsapp/wails/v2/cmd/wails@latest
[...]
github.com/tdewolff/parse/strconv
# runtime/internal/sys
/usr/local/go/src/runtime/internal/sys/stubs.go:9:7: PtrSize redeclared in this block
	/usr/local/go/src/runtime/internal/sys/arch.go:24:38: previous declaration
/usr/local/go/src/runtime/internal/sys/stubs.go:10:24: undefined: Uintreg
/usr/local/go/src/runtime/internal/sys/stubs.go:16:7: StackGuardMultiplier redeclared in this block
	/usr/local/go/src/runtime/internal/sys/arch.go:27:74: previous declaration
$:~/deliverables/hamster/hamster-client$ wails doctor
-bash: wails: command not found

I tried different versions of go, removing and reinstalling, all to no avail.

Also:

  • Starting a node with docker-compose fails. Can you fix or remove the docker-compose file?
  • Building hamster-provider initially failed because I was missing the libvirt-dev package.

@LwwL-123
Copy link
Contributor

Thank you for your use, for the installation of wails, we are using the operating system ubuntu20 and the go version is 17.2. The implementation of the install wails command is as follows.

WechatIMG376

1611648618258_ pic

Then configure the path, the documentation has been added to hamster-client, add the following statement to ~/.bash_profile: export GOROOT=/usr/local/go, Replace /usr/local/go with your go directory, and run source ~/.bash_profile. The specific installation process can be viewed on the wails official website

Also:

  • Regarding the docker-compose startup node issue, you need to change YourOwnPath and YourNodeName to start successfully, to avoid ambiguity, we have updated docker-compose.

  • Regarding missing the libvirt-dev package, I'm sorry we missed it, but it has been updated README

@semuelle
Copy link
Member

Hey @ltmuyuan. Thanks for the update.

Regarding wails: as you can see from my comment above, I did try to install and run wails, but other than some cryptic output, nothing was happening. It is fixed now, I believe it had to do with GOPATH being ~/go/bin by default from Go 1.18 onwards: https://go.dev/doc/go1.8#gopath

I don't see changes to the docker-compose file, did you perhaps forget to push it?

I was able to follow the hamster-doc tutorial up to the point of starting the provider. There is, however, no frontend reachable at port 3100, as described in your doc. Only at 10771.

When I try to update the basic information there, I get a 404 error: POST http://localhost:10771/api/api/v1/config/settting. It seems that the URL should be http://localhost:10771/api/v1/config/settting instead. Can you confirm this?

@LwwL-123
Copy link
Contributor

Thank you for your reply, for docker-compose, I am sorry for misunderstanding you, we have updated docker-compose now.

For the 3100 port unreachable issue, we found that the tutorial we provided only has build but not run on the frontend, you should use npm run serve, the documentation has been fixed now.

As for the api issue, we have fixed it, please check the latest pull.

@semuelle
Copy link
Member

semuelle commented Mar 31, 2022

Hey @LwwL-123, thanks for the update.

I was now able to change the settings, set up my resource and start the service from the frontend. I'm overall quite impressed with the system. The only things I haven't been able to do are:

  • building the hamster client. wails build fails with
    -  Building for production...
     ERROR  TypeError: Cannot read properties of undefined (reading 'NormalModule')
    TypeError: Cannot read properties of undefined (reading 'NormalModule')
        at VueLoaderPlugin.apply (/home/sebastian/work/w3f/code/grants/deliverables/hamster/hamster-client/frontend/node_modules/vue-loader-v16/dist/pluginWebpack5.js:44:47)
        at webpack (/home/sebastian/work/w3f/code/grants/deliverables/hamster/hamster-client/frontend/node_modules/@vue/cli-service/node_modules/webpack/lib/webpack.js:51:13)
        at /home/sebastian/work/w3f/code/grants/deliverables/hamster/hamster-client/frontend/node_modules/@vue/cli-service/lib/commands/build/index.js:200:5
        at new Promise (<anonymous>)
        at build (/home/sebastian/work/w3f/code/grants/deliverables/hamster/hamster-client/frontend/node_modules/@vue/cli-service/lib/commands/build/index.js:199:10)
        at async /home/sebastian/work/w3f/code/grants/deliverables/hamster/hamster-client/frontend/node_modules/@vue/cli-service/lib/commands/build/index.js:89:7
    
Error: exit status 1
  • successfully run all unit tests on the provider pallet:
---- tests::it_works_for_default_value stdout ----
thread 'tests::it_works_for_default_value' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`', pallets/provider/src/tests.rs:11:9
  • connecting to a purchased resource. The client (the binary, as I wasn't able to build it locally) crashes when I click Link and enter the port number with the following console output:
signal 11 received but handler not on signal stack
fatal error: non-Go code set up signal handler without SA_ONSTACK flag

runtime stack:
runtime: unexpected return pc for runtime.sigtramp called from 0x7fad069037ba

Can you tell me what I might be missing here?

@LwwL-123
Copy link
Contributor

LwwL-123 commented Apr 2, 2022

  • About wails build failure, this is a wails and webpack compatibility issue, we have fixed it, please pull the code, delete dist, node_modules, package-lock.json from the frontend directory where you compiled before, then go to the root directory and re-wails build. If you continue to get errors, please try changing the node version to 14, and contact us if you have any questions.

  • As for problem 2, the test error, we have fixed it.

  • As for issue 3, the crash after connecting, it is due to the IP restriction of our gateway server, you can't connect to gateway. Since gataway is under development and planned to be delivered in milestone 2, only specific gateway nodes are currently supported, we have now replaced the gateway nodes that can be connected, the program crash problem has been fixed, you need to execute rm -rf ~/.hamster-provider/config ~/.link/link.db to delete the original config file to use the new gateway node /ip4/104.43.227.20/tcp/4001/p2p/12D3KooWSWG7DFT6VkT3QXu6CTUxLKwjWwnrxuoZvcfGkizXZvLh.

@semuelle
Copy link
Member

semuelle commented Apr 6, 2022

Thanks for the update, @LwwL-123. Everything is working now. The wails issue was indeed not present with node lts/fermium.

I'm happy to report that your milestone is accepted. Congratulations. You can find my evaluation notes here.

I cannot find an invoice from you in our books. Could you, if you haven't yet, submit your invoice for this milestone through our invoice form? Please make sure that all the info that is mentioned in the form (your address, W3F's address, payment address, currency, etc.) is included in the invoice itself. Thank you.

@semuelle semuelle merged commit 410db52 into w3f:master Apr 6, 2022
@LwwL-123
Copy link
Contributor

LwwL-123 commented Apr 7, 2022

I'm happy to hear that, thanks. It looks like the invoice submission system has been updated and we have resubmitted the invoice, please contact us if you have any questions.

@semuelle
Copy link
Member

semuelle commented Apr 7, 2022

Thanks, @LwwL-123. The invoice is missing your company information, though. Can you resubmit with that added, please?

Your invoice contains your company info, consisting of name, address and if applicable VAT ID [...]

@LwwL-123
Copy link
Contributor

LwwL-123 commented Apr 7, 2022

Thank you for your reply, our company is still established, we are currently in the technical development stage, operating as a team, we will set up a company afterwards, can we write our own company information as our own team information?

@semuelle
Copy link
Member

semuelle commented Apr 7, 2022

Can you clarify what you mean by "our own company information"? Legally, we need a name and address of the recipient of the money. This can be an individual or an organisation.

@LwwL-123
Copy link
Contributor

LwwL-123 commented Apr 7, 2022

Thank you for your reply, the latest invoice has been submitted, please check it and continue to contact us if you have any questions

@fededubbi
Copy link

Good afternoon,

Can you please update the invoice with your address and send it back to invoices@web3.foundation?

Many thanks,
Regards,

Federica Dubbini

@LwwL-123
Copy link
Contributor

LwwL-123 commented Apr 7, 2022

Of course, we have sent the email, please check it

@fededubbi
Copy link

Can you put the address in english please instead of Chinese?

Many thanks,
Regards,

Federica Dubbini

@LwwL-123
Copy link
Contributor

LwwL-123 commented Apr 7, 2022

OK, we've resent it

@RouvenP
Copy link

RouvenP commented Apr 14, 2022

hi @LwwL-123, we transferred the payment today. Thanks!

@ltmuyuan
Copy link
Contributor Author

hi @RouvenP,Received with thanks.

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants