Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove thread_rng from derive.rs #50

Closed
burdges opened this issue Oct 8, 2019 · 1 comment
Closed

Remove thread_rng from derive.rs #50

burdges opened this issue Oct 8, 2019 · 1 comment

Comments

@burdges
Copy link
Collaborator

burdges commented Oct 8, 2019

We do use randomness when doing HDKD in https://docs.rs/schnorrkel/0.1.1/src/schnorrkel/derive.rs.html#177 which I should probably replace with a t.witness_bytes call so that you can replace thread_rng using attach_rng. via paritytech/substrate#3778 (comment)
@burdges
Copy link
Collaborator Author

burdges commented Oct 8, 2019

Already fixed this ages ago.

@burdges burdges closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@burdges