Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and clean up the code #86

Merged
merged 14 commits into from
Apr 13, 2023
Merged

Conversation

koute
Copy link
Collaborator

@koute koute commented Apr 13, 2023

This PR cleans up the schnorrkel code a little to prepare for a new release.

  • Switched back to curve25519-dalek from curve25519-dalek-ng (it turns out using curve25519-dalek-ng was a bad decision as that fork is effectively dead now)
  • Updated to Rust 2021
  • Removed old cruft and dead code
  • Fixed all clippy lints
  • Updated all of the dependencies
  • Cleaned up the feature flags a little
  • Marked musig as deprecated (as requested by @burdges)
  • Bumped version to 0.11.0

This should not yet be released on crates.io. Before we cut a new release I want to do two more things:

  1. Wait until my PR adding runtime SIMD autodetection is merged in curve25519-dalek and a release is cut, and then bump schnorrkel to use that. This should provide massive speedups in the range of ~30%-~50%.
  2. Do more testing. I'm going to run a full substrate burn-in to make sure nothing's accidentally broken. I might also do some fuzz testing to make sure the behavior's equivalent to the 0.9.1 version currently used by substrate.

@koute
Copy link
Collaborator Author

koute commented Apr 13, 2023

I've also added a basic Github Workflows config to have some elementary semblance of a CI.

@burdges
Copy link
Collaborator

burdges commented Apr 13, 2023

LGTM

@burdges burdges merged commit ab3e3d6 into w3f:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants