Avoid undefined indexes in notifications #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a webhook waiting information, with code similar to :
And someone does a post request without any data, it will trigger warnings like
Undefined index: sale_id
because there is basically no check made to see if the given array keys do exist.This pull request checks using
isset
to make sure the array keys do exist before trying to fetch their value. Initially i thought to set the values to empty strings if they are not set, but in my second commit i usednull
as it makes more sense in this context. I also included a test for it.Please keep in mind i am not familiar at all with how your library works internally, so please review the changes carefully.
Thank you.