Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepositoryMock should be returning promises #67

Closed
et opened this issue Mar 8, 2018 · 3 comments
Closed

RepositoryMock should be returning promises #67

et opened this issue Mar 8, 2018 · 3 comments
Assignees
@dweber019
Labels
bug

Comments

@et
Copy link
Contributor

et commented Mar 8, 2018

All the functionality in here should be returning a promise to replicate typeorm better.
@dweber019
Copy link
Member

@et thanks for your feedback. Your totally right.
Could you provide a PR with this change?

@dweber019 dweber019 self-assigned this Mar 8, 2018
@dweber019 dweber019 added the bug label Mar 8, 2018
et added a commit to et/express-typescript-boilerplate that referenced this issue Mar 8, 2018
@et
Have repo mock return promises to match typeorm more accurately.
8afd098 
Fixes w3tecch#67
@et et mentioned this issue Mar 8, 2018
Merged
@et
Copy link
Contributor Author

et commented Mar 8, 2018

#68 😄

@dweber019
Copy link
Member

@et Awesome, thanks.

hirsch88 pushed a commit that referenced this issue Mar 10, 2018
Merge branch 'develop' into feature/seed
2a6f775 
* develop:
  Have repo mock return promises to match typeorm more accurately. Fixes #67
  Add config command in setup
olivercaine added a commit to olivercaine/express-typescript-boilerplate that referenced this issue Jul 31, 2018
@olivercaine
Merge branch 'postgres-version' into mod/postgres
1400486 
* postgres-version:
  Defaulting port to 3001
  Adding dev DB config and installing UUID
  Tidyup commit
  Removing hardcoded uuid
  Auto-generate uuid
  Changing all keys to uuid
  Using uuid for User and number for Pets
  Removing comments
  WORKING removing hacky code
  WORKING PROPERLY!
  Resetting create count
  Removing length properties for int columns
  Working but not populating user_id on Pet
  Patching migrations breaking seeding
  Temporarily patching migrations breaking seeding
  Switching from MySQL to Postgres
  Adding local development Postgres DB
  Have repo mock return promises to match typeorm more accurately. Fixes w3tecch#67
  Add config command in setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweber019 dweber019

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@et @dweber019