Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My exchange number is also randomly abbreviated #205

Closed
1 task
jr8ppg opened this issue Apr 22, 2023 · 10 comments
Closed
1 task

My exchange number is also randomly abbreviated #205

jr8ppg opened this issue Apr 22, 2023 · 10 comments
Assignees
Labels
bug Something isn't working verified Bug is fixed and verified

Comments

@jr8ppg
Copy link
Collaborator

jr8ppg commented Apr 22, 2023

Description

My exchange number is also randomly abbreviated.
If the exchange type is etSerialNr, etCqZone, etItuZone, etAge, etPower, it is abbreviated by a random number.
I think my exchange number should be in a fixed format.

I am asking for your opinion please.

Steps To Reproduce

Expected behavior

Actual Behavior

Reproduces how often

Version information

  • Morse Runner version: [e.g. 1.68]
  • OS/Version: [e.g. Windows 10]

Additional context

Can you help?

Please let us know if you are available to help. (replace '[ ]' with '[x]' to affirm)

  • Yes, I'm available to help test a solution to this problem.
@jr8ppg jr8ppg added the bug Something isn't working label Apr 22, 2023
@jr8ppg
Copy link
Collaborator Author

jr8ppg commented Apr 22, 2023

How about this as a revised proposal?
bf101ea

@w7sst
Copy link
Owner

w7sst commented Apr 22, 2023

Hi,
Yes, I agree with your proposal of my station having a fixed exchange value. Good idea. This behavior matches real contests.

Thank you and best regards.

Mike W7SST

@w7sst
Copy link
Owner

w7sst commented Feb 11, 2024

Perhaps we missed the use case. In a contest, the user will want to send abbreviated numeric exchange fields. Your original concern was the random behavior. The fix turned off abbreviated fields. What we wanted to disable was the random behavior for the user's station only.

I'm going to reopen this issue. I'll submit an alternate solution that will remove the random behavior for the user's station. In other words, the user's station will always send abbreviated calls.

@w7sst w7sst reopened this Feb 11, 2024
@w7sst w7sst self-assigned this Feb 11, 2024
@jr8ppg
Copy link
Collaborator Author

jr8ppg commented Feb 11, 2024

I agree with your opinion
In contests that use serial numbers, such as WPX contests, many stations will send the replacement number in abbreviated.
Exchange numbers will either always be abbreviated or always full.

This fix code is always full.
bf101ea

@jr8ppg
Copy link
Collaborator Author

jr8ppg commented Feb 12, 2024

@w7sst
Hi Mike san
This is the revised code proposal.
c8f691a
Thank you, Taka

@w7sst
Copy link
Owner

w7sst commented Feb 13, 2024

@jr8ppg
Taka,
I uploaded a few additional changes, including some test code for cut numbers: cfd7fc3.

Once we are satisfied, I can merge mainline into your branch and we can integrate. Or, you can give the merge a try and work through the merge issues if you want, but I'll be happy to do it. Thank you again for your contributions. Let me know what you think.

BTW, I merged two Pull Requests onto mainline today. Now the IARU HF Contest is available on main.

Thank you, Mike

@jr8ppg
Copy link
Collaborator Author

jr8ppg commented Feb 13, 2024

@w7sst
Hi Mike san,
I have commented here, please refer to it.
cfd7fc3#r138573464
Thank you, Taka

@w7sst
Copy link
Owner

w7sst commented Feb 21, 2024

@jr8ppg
Hi Taka, do you have time to download and verify this fix using v1.84-rc1?

Thank you, Mike

@w7sst w7sst added the fixed - ready for validation bug is fixed; ready for validation label Feb 21, 2024
@jr8ppg
Copy link
Collaborator Author

jr8ppg commented Feb 21, 2024

@w7sst
Hi Mike san,
I'll test it tonight.
Thank you, Taka

@jr8ppg
Copy link
Collaborator Author

jr8ppg commented Feb 22, 2024

The test result was OK.

CQWW
always abbreviate
my 599 9 -> 5NN N
my 599 10 -> 5NN 1T
ok

CQWPX
randomly abbreviate
dx 599 009 -> 5NN T T N
dx 599 010 -> 5NN T 1 T
dx 599 010 -> 5NN O 1 O
ok

JARL ALLJA
dx 599 10M -> 5NN 1 T M
dx 599 10H -> 5NN 1 O H
dx 599 09M -> 5NN 0 N M
ok

@jr8ppg jr8ppg added verified Bug is fixed and verified and removed fixed - ready for validation bug is fixed; ready for validation labels Feb 22, 2024
@w7sst w7sst closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified Bug is fixed and verified
Projects
None yet
Development

No branches or pull requests

2 participants