Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling for F-Droid #6

Closed
est31 opened this issue May 8, 2015 · 21 comments
Closed

Compiling for F-Droid #6

est31 opened this issue May 8, 2015 · 21 comments

Comments

@est31
Copy link

est31 commented May 8, 2015

Hi there!

After having packaged Minilens (which is also a godot based game) for f-droid, an open-source app repository, I'd like to package tanks of freedom too. Can you tell me which git commits you built the app with? It would be best to have git tags for the different versions. Also, it would be great to have export.cfg values.

Greetings, est.

@czlowiekimadlo
Copy link
Collaborator

Hello,

Glad to see you porting our game. I assume you are asking about engine commits? We are using 1.0 devel version of the engine available on the download page. We tried using custom builds later on, but, for some reason, game does not work in them (at least on linux).

Not sure about export.cfg. We are using default values. We actually had to remove this file after each export, because it sometimes caused problems, when we were exporting to many platforms one after another.

@czlowiekimadlo
Copy link
Collaborator

I just checked Godot source repository, and there is 1.0-stable tag - I would advise trying this first.

@est31
Copy link
Author

est31 commented May 9, 2015

Thanks for pointing out to use Godot 1.0. I can't use the official build though, because 1. I need to patch godot thanks to a bug, and 2. F-Droid requires from every app to compile from source, including all dependencies.

What about game source code? It isn't tagged. Can I use the latest master, or is it not stable?
Which android:versionCode and android:versionName values would you prefer? The version code is important, android requires it to increase with new releases. Also, I'd be better to use some other unique name than com.android.noname, because this could lead to conflicts. Does io.itch.w84death.tanks-of-freedom sound good?

@czlowiekimadlo
Copy link
Collaborator

We do not tag our code, but I think we might start doing so. Master branch is rather stable, so you can use that. You would have to bundle campaign maps though (maps/blueprints/), because these are not compiled in - we are working on it.

We always did debug export for android, and did not care about these values. Production build for Google Play is on the roadmap, so we will think about these when the time comes. This unique name looks fine, you could also use in.p1x.tanks-of-freedom (we might use it for our builds)

@pizzamaker
Copy link

For reference, a submission request has been put up on F-Droid: https://f-droid.org/forums/topic/tanks-of-freedom/

@est31
Copy link
Author

est31 commented May 26, 2015

Ok, merge request is now out: https://gitlab.com/fdroid/fdroiddata/merge_requests/789
What I wonder is that building with godot 1.1 release succeeded. Its harder to use 1.0 than just changing version strings, because f-droid compilation relies on bugs to be fixed, and the fixes are only in 1.1 and not 1.0. Aside from the "can't open in editor" bug (which I can't reproduce), are there some known bugs when using 1.1? If not, I'd like to stick with it.

@w84death
Copy link
Owner

Did the maps works well on 1.1 ? Wen we switch to 1.1 (each version from beta to "stable") the map tiles were broken (we thing it's something with z-indexes). There were more little problems but less distracting.

And what OS are you using?

@est31
Copy link
Author

est31 commented May 26, 2015

I'm using Ubuntu 15.04. And yea, sometimes I have problems with map tiles seeming to overlap, but I've only experienced that in the maps editor.

@est31
Copy link
Author

est31 commented May 26, 2015

Only to check back, I do experience some other issues, too, are they in godot 1.0 also?

  • sometimes, when starting a game, instead a game CPU vs CPU starts on a fixed (so that map is always the same, regardless of which map I wanted to open; its the map you'll first see when you open the editor) map.
  • Directly after the start of the game, the map is not shown as it should be, instead its like in the map editor, e.g. the HQ building is only a blue or req square labeled "HQ". Units aren't shown at all. When I click on some building or unit, or when I just click on the "end turn" button, the map is drawn normal again. This never happens again during the game.

@w84death
Copy link
Owner

First one looks like our old bug already fixed.
Second one is purely 1.1 problem.

That's why we stick to the 1.0. 1.1 give us no features only new (and strange) bugs. But we will eventually upgrade to the newest version. We just need more time just for this task.

@est31
Copy link
Author

est31 commented May 26, 2015

Btw. hyphens aren't allowed. I'll use in.p1x.tanks_of_freedom instead.

@est31
Copy link
Author

est31 commented May 26, 2015

Using godot 1.0 now...

@est31
Copy link
Author

est31 commented May 26, 2015

Seems there are more serious problems with this one... exporting the template creates a segfault, it doesn't work at all. I think I'll abandon it, and users will have to wait until the bugs with 1.1 are fixed :)

@w84death
Copy link
Owner

Did you re-install export templates after switching to 1.0 ? Each build have their own export templates.
And remember: fixing 1.1 bugs is at the end of our backlog as 1.0 works perfectly fine.

@est31
Copy link
Author

est31 commented May 26, 2015

Yes, I've installed everything cleanly from source, including templates.

@w84death
Copy link
Owner

Did You remove export.cfg ? Sometimes when the builds crashes I need to delete export.cfg, restart Godot and it's working. That's probably the overall problem not with our code.

@est31
Copy link
Author

est31 commented May 26, 2015

I'm creating export.cfg manually with the command printf "[platform:Android]\n\npackage/icon=\"res://icon.png\"\npackage/name=\"Tanks of Freedom\"\npackage/unique_name=\"in.p1x.tanks_of_freedom\"\nversion/code=\"1\"\nversion/name=\"0.1\"\n" > tof/export.cfg
Its working with 1.1.

@czlowiekimadlo
Copy link
Collaborator

As far as I remember, we had these issues with version 1.1

  • project did not open on my Ubuntu (others did not have any issues)
  • z-index values for tilemaps are messed up
  • w84death tried exporting, and it did, but all binaries crashed after launch

I have to re-try with stable version, but I don't expect any improvement

@est31
Copy link
Author

est31 commented May 29, 2015

OK, its released on f-droid now, with godot 1.1. Thanks for the help.

@est31 est31 closed this as completed May 29, 2015
@w84death
Copy link
Owner

Thanks a lot! That's awesome :)

One thing only: can you change the description of the game to the new one (check README.md)

@est31
Copy link
Author

est31 commented May 29, 2015

ghost pushed a commit to f-droid/fdroiddata that referenced this issue May 29, 2015
Update tanks of freedom description

Game authors [have requested](w84death/Tanks-of-Freedom#6 (comment)) the change.

See merge request !794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants