Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad parsing inside ACTION without parameter (DOS possible) #54

Closed
GoogleCodeExporter opened this issue Nov 10, 2015 · 3 comments
Closed

Comments

@GoogleCodeExporter
Copy link

0000000000: 50 52 49 56 4D 53 47 20 │ 23 63 68 61 6E 6E 65 6C  PRIVMSG 
#channel
0000000010: 20 3A 01 41 43 54 49 4F │ 4E 20 20 01               :☺ACTION  
☺
'

Original issue reported on code.google.com by noel.w8tvi on 29 Sep 2008 at 6:17

@GoogleCodeExporter
Copy link
Author

Any movement on this issue? I believe it's the only thing making dircproxy 
really 
unstable at the moment..

Original comment by morte...@ifi.uio.no on 3 Jan 2009 at 7:56

@GoogleCodeExporter
Copy link
Author

Starting with the patch from 
https://bugzilla.redhat.com/show_bug.cgi?id=319301, I 
applied an almost identical patch to the current HEAD, and did some testing.

Old code (running on rev 679) crashed as before, new version, running on 694 + 
patch 
did not crash.

I'm attaching the patch, it should be enough to simply apply it.

Original comment by morte...@ifi.uio.no on 4 Jan 2009 at 4:17

Attachments:

@GoogleCodeExporter
Copy link
Author

patch applied, bug fixed.

Original comment by noel.w8tvi on 5 Jan 2009 at 12:44

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant