Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omission of x-internal operation field #71

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

nikicc
Copy link
Contributor

@nikicc nikicc commented Jan 18, 2022

This PR fixes the issue found in the latest v0.18.0 release.

x-internal is never exposed any more. I think the issue is in the omitOperationNilFields where we did not copy the value of x-internal over.

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #71 (973cd37) into master (52f6cc3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   95.18%   95.19%           
=======================================
  Files           7        7           
  Lines         956      957    +1     
=======================================
+ Hits          910      911    +1     
  Misses         30       30           
  Partials       16       16           
Impacted Files Coverage Δ
openapi/spec.go 82.05% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f6cc3...973cd37. Read the comment docs.

@nikicc nikicc marked this pull request as ready for review January 18, 2022 11:33
@nikicc
Copy link
Contributor Author

nikicc commented Jan 18, 2022

@wI2L wdyt?

@wI2L
Copy link
Owner

wI2L commented Jan 18, 2022

@nikicc Looks like it. Does the operation for which is missing has a nil Security field ?
(merged the other fix, please rebase this one, thanks)

@nikicc
Copy link
Contributor Author

nikicc commented Jan 18, 2022

@nikicc Looks like it. Does the operation for which is missing has a nil Security field ?

Yes, the Security is nil in my case. But that is a valid use-case, right?

(merged the other fix, please rebase this one, thanks)

Done.

@wI2L wI2L changed the title Fix x-internal fix: omission of x-internal operation field Jan 18, 2022
@wI2L wI2L merged commit a1906d8 into wI2L:master Jan 18, 2022
@nikicc nikicc deleted the fix-x-internal branch January 18, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants