Fix merging of multiple headers in pwnedPassword/pwnedPasswordRange (#…

…461)
wKovacs64 · Apr 28, 2024 · aa90167 · aa90167
1 parent 5fb6ceb
commit aa90167
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/.changeset/hip-donkeys-mix.md b/.changeset/hip-donkeys-mix.md
@@ -0,0 +1,5 @@
+---
+'hibp': patch
+---
+
+Fix a bug in `pwnedPassword` and `pwnedPasswordRange` modules where the `addPadding` and `userAgent` options could not be used simultaneously.
diff --git a/src/api/pwnedpasswords/fetch-from-api.ts b/src/api/pwnedpasswords/fetch-from-api.ts
@@ -40,11 +40,12 @@ export async function fetchFromApi(
     mode = 'sha1',
   } = options;
 
-  const config = Object.assign(
-    {},
-    userAgent ? { headers: { 'User-Agent': userAgent } } : {},
-    addPadding ? { headers: { 'Add-Padding': 'true' } } : {},
-  );
+  const config: RequestInit = {
+    headers: {
+      ...(userAgent ? { 'User-Agent': userAgent } : {}),
+      ...(addPadding ? { 'Add-Padding': 'true' } : {}),
+    },
+  };
   const url = `${baseUrl.replace(/\/$/g, '')}${endpoint}?mode=${mode}`;
   const response = await fetch(url, config);