Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Months grouping in Months->days #27

Closed
lukemilts opened this issue Jul 23, 2013 · 4 comments
Closed

Months grouping in Months->days #27

lukemilts opened this issue Jul 23, 2013 · 4 comments

Comments

@lukemilts
Copy link

With this domain configuration odd groupings appear in relation to those with the wider widths, that span 5 vertical weeks. Pretty sure its down to 'w(d, true) * i' style lines when calculating the x offset as this assumes that the previous months had the same larger widths.
Great plugin by the way.

@wa0x6e
Copy link
Owner

wa0x6e commented Jul 23, 2013

You means that all domains width equal the width of the larger one, and that there's sometime a gap between domains ?

I'm aware of that glitch, it's due to the fact that the dynamic width has been removed, for performance. I'll try to bring it back in 3.1, I thought that it only affect the months->weeks view.

@lukemilts
Copy link
Author

Not quite, only the domain with the larger width is affected and I don't think its a problem with widths because if you navigate the domain to be the first one (x=0) it lines up fine, so I reckon the problem is down to how each domain is positioned in the x axis. Currently from what I understand it is calculated along the lines of: x = i*w(d, true) however this assumes that all previous domains were the same width and in the case of the larger domains this is not true, thus pushing the larger domain further along in the x axis. As you can see from the screen shot the positions of all the regular width domains are fine but the larger ones get pushed along by increasing amounts. From my understanding the x position needs to be calculated from the x position of the previous domain: x = previousDomain.x + previousDomain.width + padding etc
screen shot 2013-07-23 at 9 54 37 pm
screen shot 2013-07-23 at 10 05 16 pm
In the html March and April have the correct widths (117, 140) but April has x as 140 instead of 117

@wa0x6e
Copy link
Owner

wa0x6e commented Jul 23, 2013

Try the 3.0.5 tag

@lukemilts
Copy link
Author

Thanks, the overlapping is fixed!

@wa0x6e wa0x6e closed this as completed in a83fb89 Jul 24, 2013
wa0x6e pushed a commit that referenced this issue Nov 8, 2022
…c8f660fc90

[Snyk] Upgrade karma-coverage from 2.0.3 to 2.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants